[Presentation API] Replaces type converters with typemaps

content/renderer/presentation/presentation_dispatcher.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_PRESENTATION_PRESENTATION_DISPATCHER_H_
 #define CONTENT_RENDERER_PRESENTATION_PRESENTATION_DISPATCHER_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <map>
 #include <memory>
 #include <queue>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/id_map.h"
 #include "base/macros.h"
 #include "content/common/content_export.h"
+#include "content/public/common/presentation_session.h"
 #include "content/public/renderer/render_frame_observer.h"
 #include "mojo/public/cpp/bindings/binding.h"
 #include "third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h"
 #include "third_party/WebKit/public/platform/modules/presentation/presentation.mojom.h"
 #include "url/gurl.h"
 
 namespace blink {
 class WebPresentationAvailabilityObserver;
 class WebPresentationReceiver;
 class WebString;
@@ skipping 26 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(PresentationDispatcherTest, TestSendArrayBuffer);
   FRIEND_TEST_ALL_PREFIXES(PresentationDispatcherTest, TestSendBlobData);
   FRIEND_TEST_ALL_PREFIXES(PresentationDispatcherTest, TestCloseSession);
   FRIEND_TEST_ALL_PREFIXES(PresentationDispatcherTest, TestTerminateSession);
   FRIEND_TEST_ALL_PREFIXES(PresentationDispatcherTest,
                            TestListenForScreenAvailability);
   FRIEND_TEST_ALL_PREFIXES(PresentationDispatcherTest,
                            TestSetDefaultPresentationUrls);
 
   struct SendMessageRequest {
-    SendMessageRequest(blink::mojom::PresentationSessionInfoPtr session_info,
+    SendMessageRequest(const PresentationSessionInfo& session_info,
                        blink::mojom::ConnectionMessagePtr message);
     ~SendMessageRequest();
 
-    blink::mojom::PresentationSessionInfoPtr session_info;
+    PresentationSessionInfo session_info;
     blink::mojom::ConnectionMessagePtr message;
   };
 
   static SendMessageRequest* CreateSendTextMessageRequest(
       const blink::WebURL& presentationUrl,
       const blink::WebString& presentationId,
       const blink::WebString& message);
   static SendMessageRequest* CreateSendBinaryMessageRequest(
       const blink::WebURL& presentationUrl,
       const blink::WebString& presentationId,
@@ skipping 38 matching lines @@
 
   // RenderFrameObserver implementation.
   void DidCommitProvisionalLoad(
       bool is_new_navigation,
       bool is_same_page_navigation) override;
   void OnDestruct() override;
 
   // blink::mojom::PresentationServiceClient
   void OnScreenAvailabilityNotSupported(const GURL& url) override;
   void OnScreenAvailabilityUpdated(const GURL& url, bool available) override;
-  void OnConnectionStateChanged(
-      blink::mojom::PresentationSessionInfoPtr session_info,
-      blink::mojom::PresentationConnectionState state) override;
-  void OnConnectionClosed(
-      blink::mojom::PresentationSessionInfoPtr session_info,
-      blink::mojom::PresentationConnectionCloseReason reason,
-      const std::string& message) override;
+  void OnConnectionStateChanged(const PresentationSessionInfo& session_info,
+                                PresentationConnectionState state) override;
+  void OnConnectionClosed(const PresentationSessionInfo& session_info,
+                          PresentationConnectionCloseReason reason,
+                          const std::string& message) override;
   void OnConnectionMessagesReceived(
-      blink::mojom::PresentationSessionInfoPtr session_info,
+      const PresentationSessionInfo& session_info,
       std::vector<blink::mojom::ConnectionMessagePtr> messages) override;
   void OnDefaultSessionStarted(
-      blink::mojom::PresentationSessionInfoPtr session_info) override;
+      const PresentationSessionInfo& session_info) override;
 
   void OnSessionCreated(
       std::unique_ptr<blink::WebPresentationConnectionCallback> callback,
-      blink::mojom::PresentationSessionInfoPtr session_info,
-      blink::mojom::PresentationErrorPtr error);
+      const base::Optional<PresentationSessionInfo>& session_info,
+      const base::Optional<PresentationError>& error);
   void OnReceiverConnectionAvailable(
-      blink::mojom::PresentationSessionInfoPtr,
+      const PresentationSessionInfo& session_info,
       blink::mojom::PresentationConnectionPtr,

[imcheng, 2017/01/24 23:31:40]

nit: add names for the parameters.

[nasko, 2017/01/25 17:58:16]

I wouldn't call this a nit, according to Chromium style, parameters need names
in headers.

[mark a. foltz, 2017/01/27 22:41:08]

They're unused and should be commented out per style guide.  Done.

       blink::mojom::PresentationConnectionRequest) override;
 
   // Call to PresentationService to send the message in |request|.
   // |session_info| and |message| of |reuqest| will be consumed.
   // |HandleSendMessageRequests| will be invoked after the send is attempted.
   void DoSendMessage(SendMessageRequest* request);
   void HandleSendMessageRequests(bool success);
 
   virtual void ConnectToPresentationServiceIfNeeded();
 
@@ skipping 40 matching lines @@
   // Updates the listening state of availability for |status| and notifies the
   // client.
   void UpdateListeningState(AvailabilityStatus* status);
 
   DISALLOW_COPY_AND_ASSIGN(PresentationDispatcher);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_PRESENTATION_PRESENTATION_DISPATCHER_H_