Make geolocation API and X-Geo header access consistent

chrome/browser/geolocation/geolocation_permission_context.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/geolocation/geolocation_permission_context.h"
 
 #include "base/bind.h"
 #include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/permissions/permission_request_id.h"
 #include "chrome/browser/profiles/profile.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/permission_type.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "device/geolocation/geolocation_provider.h"
+#include "url/origin.h"
 
 #if defined(OS_ANDROID)
-#include "chrome/browser/android/search_geolocation/search_geolocation_disclosure_infobar_delegate.h"
+#include "chrome/browser/android/search_geolocation/search_geolocation_service.h"
 #endif
 
 GeolocationPermissionContext::GeolocationPermissionContext(Profile* profile)
     : PermissionContextBase(profile,
                             content::PermissionType::GEOLOCATION,
                             CONTENT_SETTINGS_TYPE_GEOLOCATION),
       extensions_context_(profile) {}
 
 GeolocationPermissionContext::~GeolocationPermissionContext() {
 }
@@ skipping 19 matching lines @@
                           requesting_origin,
                           web_contents->GetLastCommittedURL().GetOrigin(),
                           callback,
                           false /* persist */,
                           content_setting);
     }
     return;
   }
 
 #if defined(OS_ANDROID)
-  // If the search geolocation disclosure is open, don't pop up a permission
-  // request. Treat this as a dismissal instead.
-  if (SearchGeolocationDisclosureInfoBarDelegate::
-          IsSearchGeolocationDisclosureOpen(web_contents)) {
+  // Consult the DSE Geolocation setting. Note that for API permission requests,
+  // this only needs to be consulted here, as it is only needed when the content
+  // setting is ASK. In the other cases (ALLOW or BLOCK) checking the setting is
+  // reduntant, as the setting is kept consistent with the content setting.
+  SearchGeolocationService* search_helper =
+      SearchGeolocationService::Factory::GetForBrowserContext(
+          web_contents->GetBrowserContext());
+  if (search_helper &&
+      search_helper->UseDSEGeolocationSetting(url::Origin(embedding_origin))) {
+    ContentSetting setting = search_helper->GetDSEGeolocationSetting()
+                                 ? CONTENT_SETTING_ALLOW
+                                 : CONTENT_SETTING_BLOCK;

[raymes, 2017/01/09 05:47:27]

As discussed I think we want to move this to GetPermissionStatus. I think we
also only want to apply the setting if the user content setting is ASK.

[benwells, 2017/01/09 21:02:22]

Done. That's much much nicer!

     NotifyPermissionSet(id, requesting_origin, embedding_origin, callback,
-                        false /* persist */, CONTENT_SETTING_DEFAULT);
+                        false /* persist */, setting);
     return;
   }
 #endif
 
   PermissionContextBase::DecidePermission(web_contents,
                                           id,
                                           requesting_origin,
                                           embedding_origin,
                                           user_gesture,
                                           callback);
@@ skipping 25 matching lines @@
 
   if (allowed) {
     device::GeolocationProvider::GetInstance()
         ->UserDidOptIntoLocationServices();
   }
 }
 
 bool GeolocationPermissionContext::IsRestrictedToSecureOrigins() const {
   return true;
 }