Add UploadProgressTracker unittest

content/browser/loader/upload_progress_tracker.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/upload_progress_tracker.h"
 
 #include "base/logging.h"
+#include "base/single_thread_task_runner.h"
 #include "net/base/upload_progress.h"
-#include "net/url_request/url_request.h"
 
 namespace content {
 namespace {
 // The interval for calls to ReportUploadProgress.
 constexpr base::TimeDelta kUploadProgressInterval =
     base::TimeDelta::FromMilliseconds(100);
 }  // namespace
 
+UploadProgressTracker::Client::Client() = default;
+UploadProgressTracker::Client::~Client() = default;
+
 UploadProgressTracker::UploadProgressTracker(
     const tracked_objects::Location& location,
-    UploadProgressReportCallback report_progress,
-    net::URLRequest* request)
-    : request_(request), report_progress_(std::move(report_progress)) {
-  DCHECK(request_);
-  DCHECK(report_progress_);
+    Client* client,
+    scoped_refptr<base::SingleThreadTaskRunner> task_runner)
+    : client_(client) {
+  DCHECK(client_);
 
+  progress_timer_.SetTaskRunner(std::move(task_runner));

[mmenke, 2017/01/06 15:54:53]

Why are we not just using the current thread?  You can add a message loop to the
test by just instantiating a base::MessageLoop in the test fixture.

[tzik, 2017/01/10 06:54:41]

That is for using TestSimpleTaskRunner::RunPendingTasks, which runs all pending
tasks including delayed tasks.
Since base::Timer posts the task as a delayed task and it posts the task
repeatedly, I think other APIs to flush the message loop doesn't work here.

   progress_timer_.Start(location, kUploadProgressInterval, this,
                         &UploadProgressTracker::ReportUploadProgressIfNeeded);
 }
 
 UploadProgressTracker::~UploadProgressTracker() {}
 
 void UploadProgressTracker::OnAckReceived() {
   waiting_for_upload_progress_ack_ = false;
 }
 
 void UploadProgressTracker::OnUploadCompleted() {
   waiting_for_upload_progress_ack_ = false;
   ReportUploadProgressIfNeeded();
   progress_timer_.Stop();
 }
 
 void UploadProgressTracker::ReportUploadProgressIfNeeded() {
   if (waiting_for_upload_progress_ack_)
     return;
 
-  net::UploadProgress progress = request_->GetUploadProgress();
+  net::UploadProgress progress = client_->GetUploadProgress();
   if (!progress.size())
     return;  // Nothing to upload.
 
   if (progress.position() == last_upload_position_)
     return;  // No progress made since last time.
 
   const uint64_t kHalfPercentIncrements = 200;
   const base::TimeDelta kOneSecond = base::TimeDelta::FromMilliseconds(1000);
 
   uint64_t amt_since_last = progress.position() - last_upload_position_;
   base::TimeDelta time_since_last = base::TimeTicks::Now() - last_upload_ticks_;
 
   bool is_finished = (progress.size() == progress.position());
   bool enough_new_progress =
       (amt_since_last > (progress.size() / kHalfPercentIncrements));
   bool too_much_time_passed = time_since_last > kOneSecond;
 
   if (is_finished || enough_new_progress || too_much_time_passed) {
-    report_progress_.Run(progress.position(), progress.size());
+    client_->ReportUploadProgress(progress.position(), progress.size());
     waiting_for_upload_progress_ack_ = true;
     last_upload_ticks_ = base::TimeTicks::Now();
     last_upload_position_ = progress.position();
   }
 }
 
 }  // namespace content