Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: chrome/browser/browsing_data/registrable_domain_filter_builder.h

Issue 2612903005: Remove the content settings dependencies from BrowsingDataFilterBuilder et al. (Closed)
Patch Set: Fixed WebsitePreferenceBridge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/registrable_domain_filter_builder.h
diff --git a/chrome/browser/browsing_data/registrable_domain_filter_builder.h b/chrome/browser/browsing_data/registrable_domain_filter_builder.h
index 1f7d1869bf27ff2643e342dbe94209abb7524f38..be0cbf07e2032b76334d49d286f674af400cd8e2 100644
--- a/chrome/browser/browsing_data/registrable_domain_filter_builder.h
+++ b/chrome/browser/browsing_data/registrable_domain_filter_builder.h
@@ -63,15 +63,6 @@ class RegistrableDomainFilterBuilder : public BrowsingDataFilterBuilder {
// or aren't in the blacklist.
base::Callback<bool(const GURL&)> BuildGeneralFilter() const override;
- // Builds a filter that calls ContentSettingsPattern::Compare on the given
- // pattern and a new pattern constructed by each domain in this filter. The
- // domain pattern A and given pattern B match when A.Compare(B) is IDENTITY
- // or PREDECESSOR. This means we only match patterns that are the same pattern
- // or a more specific pattern than our domain (so we shouldn't be matching
- // wildcard patterns like "*" or "*:80").
- base::Callback<bool(const ContentSettingsPattern& pattern)>
- BuildWebsiteSettingsPatternMatchesFilter() const override;
-
// We do a direct comparison to the registerable domain of the cookie. A
// whitelist filter will return true if any of its domains match the cookie,
// and a blacklist filter will return true only if none of its domains match

Powered by Google App Engine
This is Rietveld 408576698