Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1650)

Unified Diff: chrome/browser/android/preferences/website_preference_bridge.cc

Issue 2612903005: Remove the content settings dependencies from BrowsingDataFilterBuilder et al. (Closed)
Patch Set: Fixed WebsitePreferenceBridge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/preferences/website_preference_bridge.cc
diff --git a/chrome/browser/android/preferences/website_preference_bridge.cc b/chrome/browser/android/preferences/website_preference_bridge.cc
index f87de66a5a1e5a3f784e21d4759d8c4426c1ac7b..500fe7045577962fa2c269c6b8c252474351d4e3 100644
--- a/chrome/browser/android/preferences/website_preference_bridge.cc
+++ b/chrome/browser/android/preferences/website_preference_bridge.cc
@@ -23,7 +23,6 @@
#include "chrome/browser/browsing_data/browsing_data_quota_helper.h"
#include "chrome/browser/browsing_data/cookies_tree_model.h"
#include "chrome/browser/browsing_data/local_data_container.h"
-#include "chrome/browser/browsing_data/origin_filter_builder.h"
#include "chrome/browser/content_settings/cookie_settings_factory.h"
#include "chrome/browser/content_settings/host_content_settings_map_factory.h"
#include "chrome/browser/content_settings/tab_specific_content_settings.h"
@@ -75,13 +74,6 @@ HostContentSettingsMap* GetHostContentSettingsMap(bool is_incognito) {
GetActiveUserProfile(is_incognito));
}
-bool ForwardPrimaryPatternCallback(
- const base::Callback<bool(const ContentSettingsPattern&)> predicate,
- const ContentSettingsPattern& primary_pattern,
- const ContentSettingsPattern& secondary_pattern) {
- return predicate.Run(primary_pattern);
-}
-
typedef void (*InfoListInsertionFunction)(
JNIEnv*,
const base::android::JavaRefOrBare<jobject>&,
@@ -744,13 +736,9 @@ static void ClearCookieData(JNIEnv* env,
static void ClearBannerData(JNIEnv* env,
const JavaParamRef<jclass>& clazz,
const JavaParamRef<jstring>& jorigin) {
- OriginFilterBuilder builder(OriginFilterBuilder::WHITELIST);
- builder.AddOrigin(url::Origin(GURL(ConvertJavaStringToUTF8(env, jorigin))));
- GetHostContentSettingsMap(false)
- ->ClearSettingsForOneTypeWithPredicate(
- CONTENT_SETTINGS_TYPE_APP_BANNER,
- base::Bind(&ForwardPrimaryPatternCallback,
- builder.BuildWebsiteSettingsPatternMatchesFilter()));
+ GetHostContentSettingsMap(false)->SetWebsiteSettingDefaultScope(
+ GURL(ConvertJavaStringToUTF8(env, jorigin)), GURL(),
+ CONTENT_SETTINGS_TYPE_APP_BANNER, std::string(), nullptr);
}
// Register native methods

Powered by Google App Engine
This is Rietveld 408576698