Issue 26129010: Remove _impl from names in SkOnce.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26129010: Remove _impl from names in SkOnce.h. (Closed)

Created:
7 years, 2 months ago by mtklein

Modified:
7 years, 2 months ago

Reviewers:
bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove _impl from names in SkOnce.h. This is entirely to make power users (me, Mike's per-object use case) feel less bad about calling sk_once() directly with args not created by DEF_SK_ONCE. BUG= Committed: http://code.google.com/p/skia/source/detail?r=11686

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/core/SkOnce.h	View		4 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/26129010/1

7 years, 2 months ago (2013-10-09 19:59:08 UTC) #3

Message was sent while issue was closed.

Change committed as 11686

Expand Messages | Collapse Messages