ui/gfx/android/device_display_info.h - Issue 26129009: Cache DeviceDisplayInfo data in shared structure on native side to avoid frequent JNI calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/android/device_display_info.h

Issue 26129009: Cache DeviceDisplayInfo data in shared structure on native side to avoid frequent JNI calls. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Updated patch by review comments. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java ('K') | « ui/android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java ('k') | ui/gfx/android/device_display_info.cc » ('j') | ui/gfx/android/shared_device_display_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/gfx/android/device_display_info.h

diff --git a/ui/gfx/android/device_display_info.h b/ui/gfx/android/device_display_info.h

index c989b9849551c0a778b440c01d02cf5280535873..db65e688637d6924d9fbebf6e0128312d403a85d 100644

--- a/ui/gfx/android/device_display_info.h

+++ b/ui/gfx/android/device_display_info.h

@@ -8,7 +8,6 @@

#include <jni.h>

#include <string>

-#include "base/android/scoped_java_ref.h"

#include "base/basictypes.h"

#include "ui/gfx/gfx_export.h"

@@ -37,12 +36,7 @@ class GFX_EXPORT DeviceDisplayInfo {

// (1.0 is 160dpi, 0.75 is 120dpi, 2.0 is 320dpi).

double GetDIPScale();

- // Registers methods with JNI and returns true if succeeded.

- static bool RegisterDeviceDisplayInfo(JNIEnv* env);

private:

- base::android::ScopedJavaGlobalRef<jobject> j_device_info_;

DISALLOW_COPY_AND_ASSIGN(DeviceDisplayInfo);

};