ui/gfx/android/gfx_jni_registrar.cc - Issue 26129009: Cache DeviceDisplayInfo data in shared structure on native side to avoid frequent JNI calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/android/gfx_jni_registrar.cc

Issue 26129009: Cache DeviceDisplayInfo data in shared structure on native side to avoid frequent JNI calls. (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Updated by review comments. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/android/gfx_jni_registrar.cc

diff --git a/ui/gfx/android/gfx_jni_registrar.cc b/ui/gfx/android/gfx_jni_registrar.cc

index 8aa8551085a70526b01f2bd60a8dc1b0b2fb5aff..75cd62e6102c70d5aad731460cc2b3822232c585 100644

--- a/ui/gfx/android/gfx_jni_registrar.cc

+++ b/ui/gfx/android/gfx_jni_registrar.cc

@@ -6,14 +6,15 @@

#include "base/android/jni_android.h"

#include "base/android/jni_registrar.h"

-#include "ui/gfx/android/device_display_info.h"

#include "ui/gfx/android/java_bitmap.h"

+#include "ui/gfx/android/shared_device_display_info.h"

namespace gfx {

namespace android {

static base::android::RegistrationMethod kGfxRegisteredMethods[] = {

- { "DeviceDisplayInfo", gfx::DeviceDisplayInfo::RegisterDeviceDisplayInfo },

+ { "SharedDeviceDisplayInfo",

+ gfx::SharedDeviceDisplayInfo::RegisterSharedDeviceDisplayInfo },

Alexei Svitkine (slow) 2013/10/22 21:01:54 Nit: Remove gfx:: prefix here and below since this

ostap 2013/10/22 21:40:42 Done.

{ "JavaBitmap", gfx::JavaBitmap::RegisterJavaBitmap },

};

« no previous file with comments | « ui/gfx/android/device_display_info.cc ('k') | ui/gfx/android/shared_device_display_info.h » ('j') | ui/gfx/android/shared_device_display_info.cc » ('J')