Source/core/html/HTMLMediaElement.cpp - Issue 26129006: Fix use-after-free in HTMLMediaElement::contextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.cpp

Issue 26129006: Fix use-after-free in HTMLMediaElement::contextDestroyed (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.cpp

diff --git a/Source/core/html/HTMLMediaElement.cpp b/Source/core/html/HTMLMediaElement.cpp

index e085aab1a7fa9204758cf7aa2dd528c91866af64..25cea7fe62282e43450f63533a3d577583b49d1c 100644

--- a/Source/core/html/HTMLMediaElement.cpp

+++ b/Source/core/html/HTMLMediaElement.cpp

@@ -331,8 +331,10 @@ HTMLMediaElement::~HTMLMediaElement()

m_textTracks->item(i)->clearClient();

}

- if (m_mediaController)

+ if (m_mediaController) {

m_mediaController->removeMediaElement(this);

+ m_mediaController = 0;

+ }

closeMediaSource();

« no previous file with comments | « no previous file | no next file » | no next file with comments »