Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: extensions/browser/api/management/management_api.h

Issue 2612873004: Remove some usages of AsyncExtensionFunction::results_. (Closed)
Patch Set: sync Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/api/management/management_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/management/management_api.h
diff --git a/extensions/browser/api/management/management_api.h b/extensions/browser/api/management/management_api.h
index f1572f1f113970f0fd5ed889ca2b9f64b90eaa90..785af73f6d71fc16d27bb04a749f96cfca0b0f76 100644
--- a/extensions/browser/api/management/management_api.h
+++ b/extensions/browser/api/management/management_api.h
@@ -23,11 +23,6 @@ namespace extensions {
class ExtensionRegistry;
class RequirementsChecker;
-class AsyncManagementFunction : public AsyncExtensionFunction {
- protected:
- ~AsyncManagementFunction() override {}
-};
-
class ManagementGetAllFunction : public UIThreadExtensionFunction {
public:
DECLARE_EXTENSION_FUNCTION("management.getAll", MANAGEMENT_GETALL)
@@ -75,7 +70,7 @@ class ManagementGetPermissionWarningsByIdFunction
};
class ManagementGetPermissionWarningsByManifestFunction
- : public AsyncExtensionFunction {
+ : public UIThreadExtensionFunction {
public:
DECLARE_EXTENSION_FUNCTION("management.getPermissionWarningsByManifest",
MANAGEMENT_GETPERMISSIONWARNINGSBYMANIFEST);
@@ -88,7 +83,7 @@ class ManagementGetPermissionWarningsByManifestFunction
~ManagementGetPermissionWarningsByManifestFunction() override {}
// ExtensionFunction:
- bool RunAsync() override;
+ ResponseAction Run() override;
};
class ManagementLaunchAppFunction : public UIThreadExtensionFunction {
@@ -171,7 +166,7 @@ class ManagementUninstallSelfFunction : public ManagementUninstallFunctionBase {
ResponseAction Run() override;
};
-class ManagementCreateAppShortcutFunction : public AsyncManagementFunction {
+class ManagementCreateAppShortcutFunction : public UIThreadExtensionFunction {
public:
DECLARE_EXTENSION_FUNCTION("management.createAppShortcut",
MANAGEMENT_CREATEAPPSHORTCUT);
@@ -185,7 +180,7 @@ class ManagementCreateAppShortcutFunction : public AsyncManagementFunction {
protected:
~ManagementCreateAppShortcutFunction() override;
- bool RunAsync() override;
+ ResponseAction Run() override;
};
class ManagementSetLaunchTypeFunction : public UIThreadExtensionFunction {
@@ -199,7 +194,7 @@ class ManagementSetLaunchTypeFunction : public UIThreadExtensionFunction {
ResponseAction Run() override;
};
-class ManagementGenerateAppForLinkFunction : public AsyncManagementFunction {
+class ManagementGenerateAppForLinkFunction : public UIThreadExtensionFunction {
public:
DECLARE_EXTENSION_FUNCTION("management.generateAppForLink",
MANAGEMENT_GENERATEAPPFORLINK);
@@ -212,7 +207,7 @@ class ManagementGenerateAppForLinkFunction : public AsyncManagementFunction {
protected:
~ManagementGenerateAppForLinkFunction() override;
- bool RunAsync() override;
+ ResponseAction Run() override;
private:
std::unique_ptr<AppForLinkDelegate> app_for_link_delegate_;
« no previous file with comments | « no previous file | extensions/browser/api/management/management_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698