Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: src/preparse-data.h

Issue 261273003: Remove symbol preparse data altogether. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parser.cc ('k') | src/preparse-data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/preparse-data.h
diff --git a/src/preparse-data.h b/src/preparse-data.h
index b8cf23b5fe01b27427435632546e82fab044bc20..051a9096903aaa5c8863f60c2f2141e7488fe708 100644
--- a/src/preparse-data.h
+++ b/src/preparse-data.h
@@ -34,16 +34,6 @@ class ParserRecorder {
const char* message,
const char* argument_opt,
bool is_reference_error) = 0;
-
- // The following functions are only callable on CompleteParserRecorder
- // and are guarded by calls to ShouldLogSymbols.
- virtual void LogOneByteSymbol(int start, Vector<const uint8_t> literal) {
- UNREACHABLE();
- }
- virtual void LogTwoByteSymbol(int start, Vector<const uint16_t> literal) {
- UNREACHABLE();
- }
-
private:
DISALLOW_COPY_AND_ASSIGN(ParserRecorder);
};
@@ -158,9 +148,6 @@ class CompleteParserRecorder : public ParserRecorder {
const char* message,
const char* argument_opt,
bool is_reference_error_);
-
- virtual void LogOneByteSymbol(int start, Vector<const uint8_t> literal);
- virtual void LogTwoByteSymbol(int start, Vector<const uint16_t> literal);
Vector<unsigned> ExtractData();
private:
@@ -170,14 +157,6 @@ class CompleteParserRecorder : public ParserRecorder {
void WriteString(Vector<const char> str);
- // For testing. Defined in test-parsing.cc.
- friend struct CompleteParserRecorderFriend;
-
- void LogSymbol(int start,
- int hash,
- bool is_one_byte,
- Vector<const byte> literal);
-
// Write a non-negative number to the symbol store.
void WriteNumber(int number);
@@ -187,12 +166,6 @@ class CompleteParserRecorder : public ParserRecorder {
#ifdef DEBUG
int prev_start_;
#endif
-
- Collector<byte> literal_chars_;
- Collector<byte> symbol_store_;
- Collector<Key> symbol_keys_;
- HashMap string_table_;
- int symbol_id_;
};
« no previous file with comments | « src/parser.cc ('k') | src/preparse-data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698