Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 261273003: Remove symbol preparse data altogether. (Closed)

Created:
6 years, 7 months ago by marja
Modified:
6 years, 7 months ago
Reviewers:
dcarney
CC:
v8-dev, jochen (gone - plz use gerrit)
Visibility:
Public.

Description

Remove symbol preparse data altogether. Removing it seems to be a clear win on mobile: producing symbol data makes cold parsing 20-30% slower, and having symbol data doesn't make warm parsing any faster. Notes: - V8 used to produce symbol data, but because of a bug, it was never used until recently. (See fix https://codereview.chromium.org/172753002 which takes the symbol data into use again.) - On desktop, warm parsing is faster if we have symbol data, and producing it during cold parsing doesn't make parsing substantially slower. However, this doesn't seem to be the case on mobile. - The preparse data (cached data) will now contain only the positions of the lazy functions. BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21146

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -320 lines) Patch
M src/parser.h View 4 chunks +0 lines, -9 lines 0 comments Download
M src/parser.cc View 4 chunks +0 lines, -36 lines 0 comments Download
M src/preparse-data.h View 4 chunks +0 lines, -27 lines 0 comments Download
M src/preparse-data.cc View 2 chunks +4 lines, -108 lines 0 comments Download
M src/preparse-data-format.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/scanner.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/scanner.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +11 lines, -125 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
dcarney@, ptal, jochen@, fyi. Let's stop the symbol data madness now! Some measurements on mobile. ...
6 years, 7 months ago (2014-05-05 13:28:11 UTC) #1
dcarney
lgtm
6 years, 7 months ago (2014-05-05 13:31:44 UTC) #2
dcarney
lgtm lgtm
6 years, 7 months ago (2014-05-05 13:31:45 UTC) #3
marja
6 years, 7 months ago (2014-05-05 14:55:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r21146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698