Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart

Issue 2612723002: Implement 'analysis.analyzedFiles' notification with the new analysis driver. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart b/pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart
index f9c95aeef5e8e319c4d5ec2b996c0099f5c7788e..25cef9de9b11c947080e599339cf04758b274079 100644
--- a/pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart
@@ -17,6 +17,7 @@ import '../mocks.dart';
main() {
defineReflectiveSuite(() {
defineReflectiveTests(AnalysisNotificationAnalyzedFilesTest);
+ defineReflectiveTests(AnalysisNotificationAnalyzedFilesTest_Driver);
});
}
@@ -30,9 +31,9 @@ class AnalysisNotificationAnalyzedFilesTest extends AbstractAnalysisTest {
expect(analyzedFiles, contains(filePath));
}
- Future prepareAnalyzedFiles() {
+ Future<Null> prepareAnalyzedFiles() async {
addGeneralAnalysisSubscription(GeneralAnalysisService.ANALYZED_FILES);
- return waitForTasksFinished();
+ await pumpEventQueue();
}
void processNotification(Notification notification) {
@@ -71,12 +72,11 @@ class A {}
// not trigger the notification to be re-sent.
addTestFile('class A {}');
await prepareAnalyzedFiles();
- await waitForTasksFinished();
expect(analyzedFilesReceived, isTrue);
+
analyzedFilesReceived = false;
modifyTestFile('class B {}');
- await pumpEventQueue();
- await waitForTasksFinished();
+ await prepareAnalyzedFiles();
expect(analyzedFilesReceived, isFalse);
}
@@ -85,10 +85,11 @@ class A {}
// re-sent, even if nothing has changed.
addTestFile('class A {}');
await prepareAnalyzedFiles();
- await waitForTasksFinished();
expect(analyzedFilesReceived, isTrue);
+
unsubscribeAnalyzedFiles();
analyzedFilesReceived = false;
+
await prepareAnalyzedFiles();
expect(analyzedFilesReceived, isTrue);
assertHasFile(testFile);
@@ -98,15 +99,13 @@ class A {}
// Making a change that *does* affect the set of reachable files should
// trigger the notification to be re-sent.
addTestFile('class A {}');
- addFile('/foo.dart', 'library foo');
+ addFile('/foo.dart', 'library foo;');
await prepareAnalyzedFiles();
- await waitForTasksFinished();
expect(analyzedFilesReceived, isTrue);
+
analyzedFilesReceived = false;
modifyTestFile('import "/foo.dart";');
- await pumpEventQueue();
- await waitForTasksFinished();
- expect(analyzedFilesReceived, isTrue);
+ await prepareAnalyzedFiles();
assertHasFile('/foo.dart');
}
@@ -114,3 +113,14 @@ class A {}
removeGeneralAnalysisSubscription(GeneralAnalysisService.ANALYZED_FILES);
}
}
+
+@reflectiveTest
+class AnalysisNotificationAnalyzedFilesTest_Driver
+ extends AnalysisNotificationAnalyzedFilesTest {
+ @override
+ void setUp() {
+ enableNewAnalysisDriver = true;
+ generateSummaryFiles = true;
+ super.setUp();
+ }
+}

Powered by Google App Engine
This is Rietveld 408576698