Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2612723002: Implement 'analysis.analyzedFiles' notification with the new analysis driver. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement 'analysis.analyzedFiles' notification with the new analysis driver. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/44bab19cb311e0740bb6ddacb5b5af3406949bbc

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -15 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +11 lines, -3 lines 1 comment Download
M pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart View 6 chunks +21 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/analysis_abstract.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-04 06:00:29 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2612723002/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart File pkg/analysis_server/lib/src/operation/operation_analysis.dart (right): https://codereview.chromium.org/2612723002/diff/1/pkg/analysis_server/lib/src/operation/operation_analysis.dart#newcode138 pkg/analysis_server/lib/src/operation/operation_analysis.dart:138: // TODO(paulberry): if it proves to be too ...
3 years, 11 months ago (2017-01-04 15:01:05 UTC) #2
scheglov
3 years, 11 months ago (2017-01-04 15:12:53 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
44bab19cb311e0740bb6ddacb5b5af3406949bbc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698