chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h - Issue 2612663002: Use main frame URL to identify referrer if sub-frame url is not available

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

Issue 2612663002: Use main frame URL to identify referrer if sub-frame url is not available (Closed)

Patch Set: Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc » ('j') | chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

diff --git a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

index 9bfcfa1bb44a54f993475f9e472ace0c546b2ed0..100d2f204bb11406f62670eed9b3f5e7e94b862f 100644

--- a/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

+++ b/chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h

@@ -156,6 +156,7 @@ class SafeBrowsingNavigationObserverManager

// However, it does not prevent us to attribute url1 in Window A as the cause

// of all these navigations.

NavigationEvent* FindNavigationEvent(const GURL& target_url,

+ const GURL& target_main_frame_url,

Nathan Parker 2017/01/04 18:54:51 Mention this new arg in the comments

Jialiu Lin 2017/01/04 21:47:01 Done.

int target_tab_id);

void AddToReferrerChain(std::vector<ReferrerChainEntry>* referrer_chain,