Use main frame URL to identify referrer if sub-frame url is not available

chrome/browser/safe_browsing/safe_browsing_navigation_observer_browsertest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/safe_browsing/download_protection_service.h"
 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer.h"
@@ skipping 1036 matching lines @@
                            test_server_ip,                    // ip_address
                            GURL(),                            // referrer_url
                            GURL(),  // referrer_main_frame_url
                            false,   // is_retargeting
                            referrer_chain[1]);
 }
 
 // Click a link in a subframe and start download.
 IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest,
                        SubFrameDirectDownload) {
-  ui_test_utils::NavigateToURL(
-      browser(), embedded_test_server()->GetURL(kMultiFrameTestURL));
+  GURL initial_url = embedded_test_server()->GetURL(kSingleFrameTestURL);
+  ClickTestLink("sub_frame_download_attribution", 1, initial_url);
   std::string test_name =
       base::StringPrintf("%s', '%s", "iframe1", "iframe_direct_download");
-  GURL initial_url = embedded_test_server()->GetURL(kSingleFrameTestURL);
   GURL multi_frame_test_url =
       embedded_test_server()->GetURL(kMultiFrameTestURL);
   GURL iframe_url = embedded_test_server()->GetURL(kIframeDirectDownloadURL);
   ClickTestLink(test_name.c_str(), 1, iframe_url);
   GURL iframe_retargeting_url =
       embedded_test_server()->GetURL(kIframeRetargetingURL);
   GURL download_url = embedded_test_server()->GetURL(kDownloadItemURL);
   std::string test_server_ip(embedded_test_server()->host_port_pair().host());
   auto nav_map = navigation_map();
   ASSERT_TRUE(nav_map);
   ASSERT_EQ(std::size_t(5), nav_map->size());
   ASSERT_EQ(1U, nav_map->at(multi_frame_test_url).size());
   ASSERT_EQ(1U, nav_map->at(iframe_url).size());
   ASSERT_EQ(1U, nav_map->at(iframe_retargeting_url).size());
   ASSERT_EQ(1U, nav_map->at(download_url).size());
   ASSERT_EQ(1U, nav_map->at(initial_url).size());
   VerifyNavigationEvent(GURL(),       // source_url
                         GURL(),       // source_main_frame_url
                         initial_url,  // original_request_url
                         initial_url,  // destination_url
                         true,         // is_user_initiated,
                         true,         // has_committed
                         false,        // has_server_redirect
                         nav_map->at(initial_url).at(0));
-  VerifyNavigationEvent(GURL(),                // source_url
-                        GURL(),                // source_main_frame_url
+  VerifyNavigationEvent(initial_url,           // source_url
+                        initial_url,           // source_main_frame_url
                         multi_frame_test_url,  // original_request_url
                         multi_frame_test_url,  // destination_url
                         true,                  // is_user_initiated,
                         true,                  // has_committed
                         false,                 // has_server_redirect
                         nav_map->at(multi_frame_test_url).at(0));
   VerifyNavigationEvent(GURL(),                // source_url
                         multi_frame_test_url,  // source_main_frame_url
                         iframe_url,            // original_request_url
                         iframe_url,            // destination_url
@@ skipping 13 matching lines @@
                         multi_frame_test_url,  // source_main_frame_url
                         download_url,          // original_request_url
                         download_url,          // destination_url
                         true,                  // is_user_initiated,
                         false,                 // has_committed
                         false,                 // has_server_redirect
                         nav_map->at(download_url).at(0));
   VerifyHostToIpMap();
 
   auto referrer_chain = IdentifyReferrerChain(GetDownload());
-  ASSERT_EQ(2U, referrer_chain.size());
+  ASSERT_EQ(4U, referrer_chain.size());
   VerifyReferrerChainEntry(download_url,                      // url
                            ReferrerChainEntry::DOWNLOAD_URL,  // type
                            test_server_ip,                    // ip_address
                            iframe_url,                        // referrer_url
                            multi_frame_test_url,  // referrer_main_frame_url
                            false,                 // is_retargeting
                            referrer_chain[0]);
   VerifyReferrerChainEntry(iframe_url,                        // url
                            ReferrerChainEntry::LANDING_PAGE,  // type
                            test_server_ip,                    // ip_address
                            GURL(),                            // referrer_url
                            multi_frame_test_url,  // referrer_main_frame_url
                            false,                 // is_retargeting
                            referrer_chain[1]);
+  VerifyReferrerChainEntry(multi_frame_test_url,                 // url
+                           ReferrerChainEntry::CLIENT_REDIRECT,  // type
+                           test_server_ip,                       // ip_address
+                           initial_url,  // referrer_url
+                           initial_url,  // referrer_main_frame_url
+                           false,                 // is_retargeting
+                           referrer_chain[2]);
+  VerifyReferrerChainEntry(initial_url,                           // url
+                           ReferrerChainEntry::LANDING_REFERRER,  // type
+                           test_server_ip,                        // ip_address
+                           GURL(),  // referrer_url
+                           GURL(),  // referrer_main_frame_url
+                           false,                 // is_retargeting
+                           referrer_chain[3]);
 }
 
 // Click a link in a subframe and open download in a new tab.
 IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest,
                        SubFrameNewTabDownload) {
-  ui_test_utils::NavigateToURL(
-      browser(), embedded_test_server()->GetURL(kMultiFrameTestURL));
+  GURL initial_url = embedded_test_server()->GetURL(kSingleFrameTestURL);
+  ClickTestLink("sub_frame_download_attribution", 1, initial_url);
   std::string test_name =
       base::StringPrintf("%s', '%s", "iframe2", "iframe_new_tab_download");
-  GURL initial_url = embedded_test_server()->GetURL(kSingleFrameTestURL);
   GURL multi_frame_test_url =
       embedded_test_server()->GetURL(kMultiFrameTestURL);
   GURL iframe_url = embedded_test_server()->GetURL(kIframeDirectDownloadURL);
   GURL iframe_retargeting_url =
       embedded_test_server()->GetURL(kIframeRetargetingURL);
   ClickTestLink(test_name.c_str(), 2, iframe_retargeting_url);
   GURL blank_url = GURL(url::kAboutBlankURL);
   GURL download_url = embedded_test_server()->GetURL(kDownloadItemURL);
   std::string test_server_ip(embedded_test_server()->host_port_pair().host());
   auto nav_map = navigation_map();
   ASSERT_TRUE(nav_map);
-  ASSERT_EQ(std::size_t(6), nav_map->size());
+  ASSERT_EQ(6U, nav_map->size());
   ASSERT_EQ(1U, nav_map->at(multi_frame_test_url).size());
   ASSERT_EQ(1U, nav_map->at(iframe_url).size());
   ASSERT_EQ(1U, nav_map->at(iframe_retargeting_url).size());
   ASSERT_EQ(2U, nav_map->at(blank_url).size());
   ASSERT_EQ(1U, nav_map->at(download_url).size());
   ASSERT_EQ(1U, nav_map->at(initial_url).size());
   VerifyNavigationEvent(GURL(),       // source_url
                         GURL(),       // source_main_frame_url
                         initial_url,  // original_request_url
                         initial_url,  // destination_url
                         true,         // is_user_initiated,
                         true,         // has_committed
                         false,        // has_server_redirect
                         nav_map->at(initial_url).at(0));
-  VerifyNavigationEvent(GURL(),                // source_url
-                        GURL(),                // source_main_frame_url
+  VerifyNavigationEvent(initial_url,           // source_url
+                        initial_url,           // source_main_frame_url
                         multi_frame_test_url,  // original_request_url
                         multi_frame_test_url,  // destination_url
                         true,                  // is_user_initiated,
                         true,                  // has_committed
                         false,                 // has_server_redirect
                         nav_map->at(multi_frame_test_url).at(0));
   VerifyNavigationEvent(GURL(),                // source_url
                         multi_frame_test_url,  // source_main_frame_url
                         iframe_url,            // original_request_url
                         iframe_url,            // destination_url
@@ skipping 29 matching lines @@
                         blank_url,     // source_main_frame_url
                         download_url,  // original_request_url
                         download_url,  // destination_url
                         false,         // is_user_initiated,
                         false,         // has_committed
                         false,         // has_server_redirect
                         nav_map->at(download_url).at(0));
   VerifyHostToIpMap();
 
   auto referrer_chain = IdentifyReferrerChain(GetDownload());
-  EXPECT_EQ(std::size_t(3), referrer_chain.size());
+  EXPECT_EQ(5U, referrer_chain.size());
   VerifyReferrerChainEntry(download_url,                      // url
                            ReferrerChainEntry::DOWNLOAD_URL,  // type
                            test_server_ip,                    // ip_address
                            blank_url,                         // referrer_url
                            blank_url,  // referrer_main_frame_url
                            false,      // is_retargeting
                            referrer_chain[0]);
   VerifyReferrerChainEntry(blank_url,                            // url
                            ReferrerChainEntry::CLIENT_REDIRECT,  // type
                            "",                                   // ip_address
                            iframe_retargeting_url,               // referrer_url
                            multi_frame_test_url,  // referrer_main_frame_url
                            true,                  // is_retargeting
                            referrer_chain[1]);
   VerifyReferrerChainEntry(iframe_retargeting_url,            // url
                            ReferrerChainEntry::LANDING_PAGE,  // type
                            test_server_ip,                    // ip_address
                            GURL(),                            // referrer_url
                            multi_frame_test_url,  // referrer_main_frame_url
                            false,                 // is_retargeting
                            referrer_chain[2]);
+  VerifyReferrerChainEntry(multi_frame_test_url,                 // url
+                           ReferrerChainEntry::CLIENT_REDIRECT,  // type
+                           test_server_ip,                       // ip_address
+                           initial_url,  // referrer_url
+                           initial_url,  // referrer_main_frame_url
+                           false,                 // is_retargeting
+                           referrer_chain[3]);
+  VerifyReferrerChainEntry(initial_url,                           // url
+                           ReferrerChainEntry::LANDING_REFERRER,  // type
+                           test_server_ip,                        // ip_address
+                           GURL(),  // referrer_url
+                           GURL(),  // referrer_main_frame_url
+                           false,                 // is_retargeting
+                           referrer_chain[4]);
 }
 
 // Click a link which redirects to the landing page, and then click on the
 // landing page to trigger download.
 IN_PROC_BROWSER_TEST_F(SBNavigationObserverBrowserTest, CompleteReferrerChain) {
   GURL initial_url = embedded_test_server()->GetURL(kSingleFrameTestURL);
   ClickTestLink("complete_referrer_chain", 2, initial_url);
   GURL redirect_url = embedded_test_server()->GetURL(kRedirectToLandingURL);
   GURL landing_url = embedded_test_server()->GetURL(kLandingURL);
   ClickTestLink("download_on_landing_page", 1, landing_url);
@@ skipping 236 matching lines @@
           yesterday, embedded_test_server()->host_port_pair().host()));
   ASSERT_EQ(1U, ip_map->at(test_server_host).size());
   ClickTestLink("direct_download", 1, initial_url);
   EXPECT_EQ(1U, ip_map->at(test_server_host).size());
   EXPECT_EQ(embedded_test_server()->host_port_pair().host(),
             ip_map->at(test_server_host).back().ip);
   EXPECT_NE(yesterday, ip_map->at(test_server_host).front().timestamp);
 }
 
 }  // namespace safe_browsing