Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2612653003: Standardize errno's from a few dart:io File and Link calls (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Standardize errno's from a few dart:io File and Link calls No new tests because I'm just returning more sensical errors in cases that were already errors. Not touching Windows. It's doing its own thing. fixes #28201, #28202, #28204 R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/5e2898887b92758afef1966f17977931430fdd91

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -369 lines) Patch
M runtime/bin/file_android.cc View 2 chunks +96 lines, -104 lines 0 comments Download
M runtime/bin/file_fuchsia.cc View 2 chunks +87 lines, -96 lines 0 comments Download
M runtime/bin/file_linux.cc View 2 chunks +96 lines, -105 lines 0 comments Download
M runtime/bin/file_macos.cc View 2 chunks +54 lines, -64 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
zra
3 years, 11 months ago (2017-01-04 18:25:00 UTC) #3
Cutch
Would be nice to add regression tests that make sure the error codes stay like ...
3 years, 11 months ago (2017-01-04 18:28:45 UTC) #4
zra
3 years, 11 months ago (2017-01-04 21:09:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5e2898887b92758afef1966f17977931430fdd91 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698