Web MIDI: add an unit test to check MidiManager instantiation

media/midi/midi_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/midi/midi_manager.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/message_loop/message_loop.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace media {
 
 namespace {
 
 class FakeMidiManager : public MidiManager {
  public:
   FakeMidiManager()
       : start_initialization_is_called_(false),
@@ skipping 27 matching lines @@
 
   bool start_initialization_is_called_;
   bool complete_initialization_synchronously_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(FakeMidiManager);
 };
 
 class FakeMidiManagerClient : public MidiManagerClient {
  public:
-  FakeMidiManagerClient(int client_id) : client_id_(client_id) {}
+  FakeMidiManagerClient(int client_id)

[yukawa, 2014/05/04 23:16:02]

explicit?

[Takashi Toyoshima, 2014/05/05 00:45:08]

Done.

+      : client_id_(client_id),
+        result_(MIDI_NOT_SUPPORTED),
+        wait_for_result_(true) {}
   virtual ~FakeMidiManagerClient() {}
 
   // MidiManagerClient implementation.
   virtual void CompleteStartSession(int client_id, MidiResult result) OVERRIDE {
-    DCHECK_EQ(client_id_, client_id);
+    CHECK_EQ(client_id_, client_id);
     result_ = result;
+    wait_for_result_ = false;
   }
 
   virtual void ReceiveMidiData(uint32 port_index, const uint8* data,
                                size_t size, double timestamp) OVERRIDE {}
   virtual void AccumulateMidiBytesSent(size_t size) OVERRIDE {}
 
   int GetClientId() {

[yukawa, 2014/05/04 23:16:02]

[optional] int GetClientId() const {

[Takashi Toyoshima, 2014/05/05 00:45:08]

Done.

     return client_id_;
   }
 
   MidiResult GetResult() {

[yukawa, 2014/05/04 23:16:02]

[optiona] MidiResult GetResult() const {

[Takashi Toyoshima, 2014/05/05 00:45:08]

Done.

     return result_;
   }
 
+  MidiResult WaitForResult() {
+    while (wait_for_result_)
+      base::MessageLoop::current()->Run();
+    return GetResult();
+  }
+
  private:
   int client_id_;
   MidiResult result_;
+  bool wait_for_result_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeMidiManagerClient);
 };
 
 class MidiManagerTest : public ::testing::Test {
  public:
-  MidiManagerTest() : manager_(new FakeMidiManager) {}
+  MidiManagerTest()
+      : message_loop_(new base::MessageLoop), manager_(new FakeMidiManager) {}
   virtual ~MidiManagerTest() {}
 
  protected:
   void StartTheFirstSession(FakeMidiManagerClient* client,
                             bool complete_initialization_synchronously) {
     manager_->complete_initialization_synchronously_ =
         complete_initialization_synchronously;
     EXPECT_FALSE(manager_->start_initialization_is_called_);
     EXPECT_EQ(0U, manager_->GetClientCount());
     EXPECT_EQ(0U, manager_->GetPendingClientCount());
@@ skipping 28 matching lines @@
     EXPECT_EQ(before, manager_->GetClientCount());
     manager_->EndSession(client);
     EXPECT_EQ(after, manager_->GetClientCount());
   }
 
   void CompleteInitialization(MidiResult result) {
     manager_->CallCompleteInitialization(result);
   }
 
  private:
+  scoped_ptr<base::MessageLoop> message_loop_;
   scoped_ptr<FakeMidiManager> manager_;
 
   DISALLOW_COPY_AND_ASSIGN(MidiManagerTest);
 };
 
 // Check if calling CompleteInitialization() does not acquire the same lock

[Takashi Toyoshima, 2014/05/05 00:45:08]

Now that CompleteStartSession is invoked always asynchronously. So this test
case is not needed any more.

 // on the same thread.
 TEST_F(MidiManagerTest, StartAndEndSessionSynchronously) {
   scoped_ptr<FakeMidiManagerClient> client;
   client.reset(new FakeMidiManagerClient(0));
 
   StartTheFirstSession(client.get(), true);
   EndSession(client.get(), 1U, 0U);
 }
 
 TEST_F(MidiManagerTest, StartAndEndSession) {
@@ skipping 24 matching lines @@
 
   StartTheFirstSession(client1.get(), false);
   StartTheSecondSession(client2.get());
   CompleteInitialization(MIDI_OK);
   EXPECT_EQ(MIDI_OK, client1->GetResult());
   EXPECT_EQ(MIDI_OK, client2->GetResult());
   EndSession(client1.get(), 2U, 1U);
   EndSession(client2.get(), 1U, 0U);
 }
 
+TEST_F(MidiManagerTest, CreateMidiManager) {
+  scoped_ptr<FakeMidiManagerClient> client;
+  client.reset(new FakeMidiManagerClient(0));
+
+  scoped_ptr<MidiManager> manager(MidiManager::Create());
+  manager->StartSession(client.get(), client->GetClientId());
+  EXPECT_EQ(MIDI_OK, client->WaitForResult());
+}
+
 }  // namespace
 
 }  // namespace media