Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 261253006: Fix %SetFlags("--stress-compaction") (Closed)

Created:
6 years, 7 months ago by Jarin
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix %SetFlags("--stress-compaction") BUG=369943 LOG=N R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21260

Patch Set 1 #

Patch Set 2 : Just remove the filler insertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M src/spaces-inl.h View 1 1 chunk +0 lines, -15 lines 0 comments Download
A + test/mjsunit/regress/regress-set-flags-stress-compact.js View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jarin
6 years, 7 months ago (2014-05-06 10:20:46 UTC) #1
Hannes Payer (out of office)
I find the dependency between stress_compaction and gc_global weird. Anyhow, as you pointed out with ...
6 years, 7 months ago (2014-05-06 15:18:17 UTC) #2
Jarin
On 2014/05/06 15:18:17, Hannes Payer wrote: > I find the dependency between stress_compaction and gc_global ...
6 years, 7 months ago (2014-05-07 06:38:13 UTC) #3
Hannes Payer (out of office)
lgtm
6 years, 7 months ago (2014-05-07 07:32:04 UTC) #4
Jarin
6 years, 7 months ago (2014-05-12 10:39:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r21260 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698