Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1407)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2612423002: Track composition range information on the browser side (Android) (Closed)
Patch Set: Addressing creis@'s comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.h
diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h
index ec708a2dfad8d3e87314b2bd088fd4a09ea96dc5..0f7cc632df3741f29f7eac4f8d9844322fba5e43 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.h
+++ b/content/browser/renderer_host/render_widget_host_view_android.h
@@ -107,9 +107,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
void UpdateCursor(const WebCursor& cursor) override;
void SetIsLoading(bool is_loading) override;
void ImeCancelComposition() override;
- void ImeCompositionRangeChanged(
- const gfx::Range& range,
- const std::vector<gfx::Rect>& character_bounds) override;
void FocusedNodeChanged(bool is_editable_node,
const gfx::Rect& node_bounds_in_screen) override;
void RenderProcessGone(base::TerminationStatus status,
@@ -258,6 +255,9 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid
void OnUpdateTextInputStateCalled(TextInputManager* text_input_manager,
RenderWidgetHostViewBase* updated_view,
bool did_change_state) override;
+ void OnImeCompositionRangeChanged(
+ TextInputManager* text_input_manager,
+ RenderWidgetHostViewBase* updated_view) override;
private:
void RunAckCallbacks();

Powered by Google App Engine
This is Rietveld 408576698