Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1848)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2612423002: Track composition range information on the browser side (Android) (Closed)
Patch Set: Addressing creis@'s comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 14a6ee88667a08016c6308181c668b9c0ec8afec..03fa5b38797e7138ee885e772fb07d2053477c42 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -781,6 +781,22 @@ void RenderWidgetHostViewAndroid::OnUpdateTextInputStateCalled(
state.is_non_ime_change);
}
+void RenderWidgetHostViewAndroid::OnImeCompositionRangeChanged(
+ TextInputManager* text_input_manager,
+ RenderWidgetHostViewBase* updated_view) {
+ DCHECK_EQ(text_input_manager_, text_input_manager);
+ const TextInputManager::CompositionRangeInfo* info =
+ text_input_manager_->GetCompositionRangeInfo();
+ if (!info)
+ return;
+
+ std::vector<gfx::RectF> character_bounds;
+ for (const gfx::Rect& rect : info->character_bounds)
+ character_bounds.emplace_back(rect);
+
+ ime_adapter_android_.SetCharacterBounds(character_bounds);
+}
+
void RenderWidgetHostViewAndroid::UpdateBackgroundColor(SkColor color) {
if (cached_background_color_ == color)
return;
@@ -908,15 +924,6 @@ void RenderWidgetHostViewAndroid::ImeCancelComposition() {
ime_adapter_android_.CancelComposition();
}
-void RenderWidgetHostViewAndroid::ImeCompositionRangeChanged(
- const gfx::Range& range,
- const std::vector<gfx::Rect>& character_bounds) {
- std::vector<gfx::RectF> character_bounds_float;
- for (const gfx::Rect& rect : character_bounds) {
- character_bounds_float.emplace_back(rect);
- }
- ime_adapter_android_.SetCharacterBounds(character_bounds_float);
-}
void RenderWidgetHostViewAndroid::FocusedNodeChanged(
bool is_editable_node,

Powered by Google App Engine
This is Rietveld 408576698