Track composition range information on the browser side (Android)

content/browser/renderer_host/render_widget_host_view_android.cc

Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 14a6ee88667a08016c6308181c668b9c0ec8afec..b03321362cf9c2a71ddd3743967a355a9e178165 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -781,6 +781,22 @@ void RenderWidgetHostViewAndroid::OnUpdateTextInputStateCalled(
       state.is_non_ime_change);
 }
 
+void RenderWidgetHostViewAndroid::OnImeCompositionRangeChanged(
+    TextInputManager* text_input_manager,
+    RenderWidgetHostViewBase* updated_view) {
+  DCHECK_EQ(text_input_manager_, text_input_manager);
+  const TextInputManager::CompositionRangeInfo* info =
+      text_input_manager_->GetCompositionRangeInfo();
+  if (!info)
+    return;
+
+  std::vector<gfx::RectF> character_bounds_float;

[Charlie Reis, 2017/01/06 22:22:39]

nit: character_bounds

[EhsanK, 2017/01/06 22:37:16]

Acknowledged.

+  for (const gfx::Rect& rect : info->character_bounds) {

[Charlie Reis, 2017/01/06 22:22:40]

nit: No braces needed.

[EhsanK, 2017/01/06 22:37:16]

Acknowledged.

+    character_bounds_float.emplace_back(rect);
+  }
+  ime_adapter_android_.SetCharacterBounds(character_bounds_float);
+}
+
 void RenderWidgetHostViewAndroid::UpdateBackgroundColor(SkColor color) {
   if (cached_background_color_ == color)
     return;
@@ -908,15 +924,6 @@ void RenderWidgetHostViewAndroid::ImeCancelComposition() {
   ime_adapter_android_.CancelComposition();
 }
 
-void RenderWidgetHostViewAndroid::ImeCompositionRangeChanged(
-    const gfx::Range& range,
-    const std::vector<gfx::Rect>& character_bounds) {
-  std::vector<gfx::RectF> character_bounds_float;
-  for (const gfx::Rect& rect : character_bounds) {
-    character_bounds_float.emplace_back(rect);
-  }
-  ime_adapter_android_.SetCharacterBounds(character_bounds_float);
-}
 
 void RenderWidgetHostViewAndroid::FocusedNodeChanged(
     bool is_editable_node,