Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1674)

Unified Diff: cc/layers/picture_layer_impl_unittest.cc

Issue 2612413003: Clean up tile deletion (Closed)
Patch Set: "Fix Tile* comparison in tests" Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/test/fake_picture_layer_tiling_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/picture_layer_impl_unittest.cc
diff --git a/cc/layers/picture_layer_impl_unittest.cc b/cc/layers/picture_layer_impl_unittest.cc
index be322f67ff513e36f46737d5539b3ed937d23dd0..a00ae19f54a5e177328db9fe12eae615b91f1eeb 100644
--- a/cc/layers/picture_layer_impl_unittest.cc
+++ b/cc/layers/picture_layer_impl_unittest.cc
@@ -4478,9 +4478,9 @@ TEST_F(PictureLayerImplTest, CloneMissingRecordings) {
SetupPendingTreeWithFixedTileSize(filled_raster_source, tile_size,
Region(gfx::Rect(layer_bounds)));
EXPECT_EQ(5u * 5u, pending_tiling->AllTilesForTesting().size());
- Tile* tile00 = pending_tiling->TileAt(0, 0);
- Tile* tile11 = pending_tiling->TileAt(1, 1);
- Tile* tile22 = pending_tiling->TileAt(2, 2);
+ Tile::Id tile00 = pending_tiling->TileAt(0, 0)->id();
+ Tile::Id tile11 = pending_tiling->TileAt(1, 1)->id();
+ Tile::Id tile22 = pending_tiling->TileAt(2, 2)->id();
// Active is not affected yet.
EXPECT_EQ(3u * 3u, active_tiling->AllTilesForTesting().size());
@@ -4488,9 +4488,9 @@ TEST_F(PictureLayerImplTest, CloneMissingRecordings) {
// Activate the tree. The tiles are moved to the active tree.
ActivateTree();
EXPECT_EQ(5u * 5u, active_tiling->AllTilesForTesting().size());
- EXPECT_EQ(tile00, active_tiling->TileAt(0, 0));
- EXPECT_EQ(tile11, active_tiling->TileAt(1, 1));
- EXPECT_EQ(tile22, active_tiling->TileAt(2, 2));
+ EXPECT_EQ(tile00, active_tiling->TileAt(0, 0)->id());
+ EXPECT_EQ(tile11, active_tiling->TileAt(1, 1)->id());
+ EXPECT_EQ(tile22, active_tiling->TileAt(2, 2)->id());
}
TEST_F(PictureLayerImplTest, ScrollPastLiveTilesRectAndBack) {
@@ -4771,8 +4771,8 @@ TEST_F(PictureLayerImplTest, HighResWasLowResCollision) {
// Grab a current low res tile.
PictureLayerTiling* old_low_res_tiling =
active_layer()->tilings()->tiling_at(1);
- Tile* old_low_res_tile =
- active_layer()->tilings()->tiling_at(1)->TileAt(0, 0);
+ Tile::Id old_low_res_tile_id =
+ active_layer()->tilings()->tiling_at(1)->TileAt(0, 0)->id();
// The tiling knows it has low res content.
EXPECT_TRUE(active_layer()
@@ -4801,7 +4801,7 @@ TEST_F(PictureLayerImplTest, HighResWasLowResCollision) {
// The old low res tile was destroyed and replaced.
EXPECT_EQ(old_low_res_tiling, tilings->tiling_at(1));
- EXPECT_NE(old_low_res_tile, tilings->tiling_at(1)->TileAt(0, 0));
+ EXPECT_NE(old_low_res_tile_id, tilings->tiling_at(1)->TileAt(0, 0)->id());
EXPECT_TRUE(tilings->tiling_at(1)->TileAt(0, 0));
// New high res tiling.
« no previous file with comments | « cc/layers/picture_layer_impl.cc ('k') | cc/test/fake_picture_layer_tiling_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698