Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/timeline_model/TimelineModel.js

Issue 2612363003: DevTools: Show FMP markers on timeline experiment (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 101
102 /** 102 /**
103 * @param {!SDK.TracingModel.Event} event 103 * @param {!SDK.TracingModel.Event} event
104 * @return {boolean} 104 * @return {boolean}
105 */ 105 */
106 static isMarkerEvent(event) { 106 static isMarkerEvent(event) {
107 var recordTypes = TimelineModel.TimelineModel.RecordType; 107 var recordTypes = TimelineModel.TimelineModel.RecordType;
108 switch (event.name) { 108 switch (event.name) {
109 case recordTypes.TimeStamp: 109 case recordTypes.TimeStamp:
110 case recordTypes.MarkFirstPaint: 110 case recordTypes.MarkFirstPaint:
111 case recordTypes.FMPCandidate:
111 return true; 112 return true;
112 case recordTypes.MarkDOMContent: 113 case recordTypes.MarkDOMContent:
113 case recordTypes.MarkLoad: 114 case recordTypes.MarkLoad:
114 return event.args['data']['isMainFrame']; 115 return event.args['data']['isMainFrame'];
115 default: 116 default:
116 return false; 117 return false;
117 } 118 }
118 } 119 }
119 120
120 /** 121 /**
(...skipping 1069 matching lines...) Expand 10 before | Expand all | Expand 10 after
1190 1191
1191 XHRReadyStateChange: 'XHRReadyStateChange', 1192 XHRReadyStateChange: 'XHRReadyStateChange',
1192 XHRLoad: 'XHRLoad', 1193 XHRLoad: 'XHRLoad',
1193 CompileScript: 'v8.compile', 1194 CompileScript: 'v8.compile',
1194 EvaluateScript: 'EvaluateScript', 1195 EvaluateScript: 'EvaluateScript',
1195 1196
1196 CommitLoad: 'CommitLoad', 1197 CommitLoad: 'CommitLoad',
1197 MarkLoad: 'MarkLoad', 1198 MarkLoad: 'MarkLoad',
1198 MarkDOMContent: 'MarkDOMContent', 1199 MarkDOMContent: 'MarkDOMContent',
1199 MarkFirstPaint: 'MarkFirstPaint', 1200 MarkFirstPaint: 'MarkFirstPaint',
1201 FMPCandidate: 'firstMeaningfulPaintCandidate',
pfeldman 2017/01/06 00:05:59 firstMeaningfulPaint also exists. And we can displ
alph 2017/01/06 01:56:48 Done.
1200 1202
1201 TimeStamp: 'TimeStamp', 1203 TimeStamp: 'TimeStamp',
1202 ConsoleTime: 'ConsoleTime', 1204 ConsoleTime: 'ConsoleTime',
1203 UserTiming: 'UserTiming', 1205 UserTiming: 'UserTiming',
1204 1206
1205 ResourceSendRequest: 'ResourceSendRequest', 1207 ResourceSendRequest: 'ResourceSendRequest',
1206 ResourceReceiveResponse: 'ResourceReceiveResponse', 1208 ResourceReceiveResponse: 'ResourceReceiveResponse',
1207 ResourceReceivedData: 'ResourceReceivedData', 1209 ResourceReceivedData: 'ResourceReceivedData',
1208 ResourceFinish: 'ResourceFinish', 1210 ResourceFinish: 'ResourceFinish',
1209 1211
(...skipping 821 matching lines...) Expand 10 before | Expand all | Expand 10 after
2031 var data = event[TimelineModel.TimelineData._symbol]; 2033 var data = event[TimelineModel.TimelineData._symbol];
2032 if (!data) { 2034 if (!data) {
2033 data = new TimelineModel.TimelineData(); 2035 data = new TimelineModel.TimelineData();
2034 event[TimelineModel.TimelineData._symbol] = data; 2036 event[TimelineModel.TimelineData._symbol] = data;
2035 } 2037 }
2036 return data; 2038 return data;
2037 } 2039 }
2038 }; 2040 };
2039 2041
2040 TimelineModel.TimelineData._symbol = Symbol('timelineData'); 2042 TimelineModel.TimelineData._symbol = Symbol('timelineData');
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698