Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2612273003: dart2js-kernel: do not crash on missing const initializers (Closed)

Created:
3 years, 11 months ago by sra1
Modified:
3 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js-kernel: do not crash on missing const initializers Compilation will fail, but only after compiling functions that might use the constants. BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/5305e8685c71c83ac07b94c35a8c52ce51d60e55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sra1
3 years, 11 months ago (2017-01-06 01:58:46 UTC) #3
Emily Fortuna
lgtm
3 years, 11 months ago (2017-01-06 02:16:17 UTC) #4
sra1
3 years, 11 months ago (2017-01-06 18:34:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5305e8685c71c83ac07b94c35a8c52ce51d60e55 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698