third_party/WebKit/Source/bindings/core/v8/BUILD.gn - Issue 2612263002: Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

Issue 2612263002: Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec. (Closed)

Patch Set: Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/BUILD.gn

diff --git a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn

index 7a0a9a30672eb1ffb4144ccf7887364075b17042..28ac8c453a696b6fa1b06b4935f0d2aaea8e745b 100644

--- a/third_party/WebKit/Source/bindings/core/v8/BUILD.gn

+++ b/third_party/WebKit/Source/bindings/core/v8/BUILD.gn

@@ -29,6 +29,8 @@ generated_core_dictionary_files = [

"$blink_core_output_dir/css/cssom/CSSCalcDictionary.h",

"$blink_core_output_dir/dom/DOMPointInit.cpp",

"$blink_core_output_dir/dom/DOMPointInit.h",

+ "$blink_core_output_dir/dom/DOMRectInit.cpp",

zino 2017/01/11 18:43:35 nit: Please keep alphabetical order.

Byoungkwon Ko 2017/01/12 17:24:17 Done.

+ "$blink_core_output_dir/dom/DOMRectInit.h",

"$blink_core_output_dir/dom/DOMMatrixInit.cpp",

"$blink_core_output_dir/dom/DOMMatrixInit.h",

"$blink_core_output_dir/dom/ElementCreationOptions.cpp",