Issue 2612253002: Fix needsNoSuchMethod computation for abstractly instantiated classes

Issue 2612253002: Fix needsNoSuchMethod computation for abstractly instantiated classes (Closed)

Created:
3 years, 11 months ago by Johnni Winther

Modified:
3 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google), zra, floitsch

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix needsNoSuchMethod computation for abstractly instantiated classes R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/12491d4ab869b903870b0783c5fd715e8307b47d

Patch Set 2 : dartfmt #

Total comments: 1

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -2 lines)			Patch
M	pkg/compiler/lib/src/world.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/compiler/dart2js/jsinterop/world_test.dart	View	1	3 chunks	+14 lines, -1 line	0 comments	Download
A	tests/language/regress_28255_test.dart	View		1 chunk	+23 lines, -0 lines	1 comment	Download

Messages

Total messages: 9 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

Committed patchset #2 (id:20001) manually as 12491d4ab869b903870b0783c5fd715e8307b47d (presubmit successful).

3 years, 11 months ago (2017-01-05 15:42:46 UTC) #5

zra

https://codereview.chromium.org/2612253002/diff/20001/tests/language/regress_28255_test.dart File tests/language/regress_28255_test.dart (right): https://codereview.chromium.org/2612253002/diff/20001/tests/language/regress_28255_test.dart#newcode7 tests/language/regress_28255_test.dart:7: import 'dart:mirrors'; It looks like you need to SkipByDesign ...

3 years, 11 months ago (2017-01-05 16:02:02 UTC) #7

Message was sent while issue was closed.

I will mark it as a gardener.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages