DirectCompositorFrameSink Uses CompositorFrameSinkSupport

cc/surfaces/surface_manager.cc

Index: cc/surfaces/surface_manager.cc
diff --git a/cc/surfaces/surface_manager.cc b/cc/surfaces/surface_manager.cc
index 94bdac6aceaf9382966fc5dedcc45262303c0837..61312e297657f10eb3f2db5f18f87719367cc50e 100644
--- a/cc/surfaces/surface_manager.cc
+++ b/cc/surfaces/surface_manager.cc
@@ -121,8 +121,7 @@ void SurfaceManager::SatisfySequence(const SurfaceSequence& sequence) {
 }
 
 void SurfaceManager::RegisterFrameSinkId(const FrameSinkId& frame_sink_id) {
-  bool inserted = valid_frame_sink_ids_.insert(frame_sink_id).second;
-  DCHECK(inserted);
+  valid_frame_sink_ids_.insert(frame_sink_id);

[boliu, 2017/01/26 22:39:41]

why drop this DCHECK? is client inserting duplicates now, then that should be
fixed?

[Alex Z., 2017/01/27 20:27:02]

From fsamuel@'s comment:

ui::Compositor Registers the FrameSinkId first:
https://cs.chromium.org/chromium/src/ui/compositor/compositor.cc?sq=package:c...

However, we eventually want to get rid of that in favor of the SurfaceReference
approach to reference tracking. We're not there yet. For the time being, we are
registering the FrameSinkId in CompositorFrameSinkSupport. However, while we're
using SurfaceSequences, we cannot get rid of RegisterFrameSinkId in
ui::Compositor, so I thought getting rid of the DCHECK would be easier for now.

Note that once SurfaceReferences are used everywhere, RegisterFrameSinkId and
InvalidateFrameSinkId will likely go away.

 }
 
 void SurfaceManager::InvalidateFrameSinkId(const FrameSinkId& frame_sink_id) {