DirectCompositorFrameSink Uses CompositorFrameSinkSupport

content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.h"
 
 #include "base/memory/ptr_util.h"
 #include "cc/surfaces/surface.h"
 #include "cc/surfaces/surface_manager.h"
 #include "content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_provider_impl.h"
 #include "mojo/public/cpp/bindings/strong_binding.h"
 
 namespace content {
 
 OffscreenCanvasCompositorFrameSink::OffscreenCanvasCompositorFrameSink(
     OffscreenCanvasCompositorFrameSinkProviderImpl* provider,
     const cc::FrameSinkId& frame_sink_id,
     cc::mojom::MojoCompositorFrameSinkRequest request,
     cc::mojom::MojoCompositorFrameSinkClientPtr client)
     : provider_(provider),
       support_(this,
                provider->GetSurfaceManager(),
                frame_sink_id,
                nullptr,
-               nullptr),
+               true,

[Fady Samuel, 2017/02/07 17:42:18]

Please specify what these trues mean: e.g. true /*
handles_frame_sink_id_invalidation */, true /* needs_sync_points*/

[Alex Z., 2017/02/07 17:47:50]

Done.

[danakj, 2017/02/07 17:47:55]

and here

[Alex Z., 2017/02/07 17:51:33]

Done.

+               true),
       client_(std::move(client)),
       binding_(this, std::move(request)) {
   binding_.set_connection_error_handler(
       base::Bind(&OffscreenCanvasCompositorFrameSink::OnClientConnectionLost,
                  base::Unretained(this)));
 }
 
 OffscreenCanvasCompositorFrameSink::~OffscreenCanvasCompositorFrameSink() {
   provider_->OnCompositorFrameSinkClientDestroyed(support_.frame_sink_id());
 }
@@ skipping 47 matching lines @@
   if (client_)
     client_->WillDrawSurface();
 }
 
 void OffscreenCanvasCompositorFrameSink::OnClientConnectionLost() {
   provider_->OnCompositorFrameSinkClientConnectionLost(
       support_.frame_sink_id());
 }
 
 }  // namespace content