ui/android/window_android_compositor.h - Issue 2612083002: DirectCompositorFrameSink Uses CompositorFrameSinkSupport

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/android/window_android_compositor.h

Issue 2612083002: DirectCompositorFrameSink Uses CompositorFrameSinkSupport (Closed)

Patch Set: set has_compositor_frame_sink_ to false in SetVisible(false) Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/renderer_host/compositor_impl_android.cc ('K') | « services/ui/surfaces/gpu_compositor_frame_sink.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef UI_ANDROID_WINDOW_ANDROID_COMPOSITOR_H_	5 #ifndef UI_ANDROID_WINDOW_ANDROID_COMPOSITOR_H_

6 #define UI_ANDROID_WINDOW_ANDROID_COMPOSITOR_H_	6 #define UI_ANDROID_WINDOW_ANDROID_COMPOSITOR_H_

7	7

8 #include <memory>	8 #include <memory>

9	9

10 #include "cc/output/copy_output_request.h"	10 #include "cc/output/copy_output_request.h"

(...skipping 12 matching lines...) Expand all Loading...
23 class UI_ANDROID_EXPORT WindowAndroidCompositor {	23 class UI_ANDROID_EXPORT WindowAndroidCompositor {

24 public:	24 public:

25 virtual ~WindowAndroidCompositor() {}	25 virtual ~WindowAndroidCompositor() {}

26	26

27 virtual void AttachLayerForReadback(scoped_refptr<cc::Layer> layer) = 0;	27 virtual void AttachLayerForReadback(scoped_refptr<cc::Layer> layer) = 0;

28 virtual void RequestCopyOfOutputOnRootLayer(	28 virtual void RequestCopyOfOutputOnRootLayer(

29 std::unique_ptr<cc::CopyOutputRequest> request) = 0;	29 std::unique_ptr<cc::CopyOutputRequest> request) = 0;

30 virtual void SetNeedsAnimate() = 0;	30 virtual void SetNeedsAnimate() = 0;

31 virtual ResourceManager& GetResourceManager() = 0;	31 virtual ResourceManager& GetResourceManager() = 0;

32 virtual cc::FrameSinkId GetFrameSinkId() = 0;	32 virtual cc::FrameSinkId GetFrameSinkId() = 0;

	33 virtual void AddChildFrameSink(cc::FrameSinkId frame_sink_id) = 0;
	boliu 2017/01/26 22:39:41 you don't need this here, this is an interface for you don't need this here, this is an interface for WindowAndroid to call up to the compositor. WindowAndroid isn't using this method RWHVA can cast the pointer to CompositorImplAndroid directly. Yes other methods are already wrong, but let's not make it worse Alex Z. 2017/01/27 20:27:02 Done. Show quoted text On 2017/01/26 22:39:41, boliu wrote: > you don't need this here, this is an interface for WindowAndroid to call up to > the compositor. WindowAndroid isn't using this method > > RWHVA can cast the pointer to CompositorImplAndroid directly. Yes other methods > are already wrong, but let's not make it worse Done.
33 };	34 };

34	35

35 } // namespace ui	36 } // namespace ui

36	37

37 #endif // UI_ANDROID_WINDOW_ANDROID_COMPOSITOR_H_	38 #endif // UI_ANDROID_WINDOW_ANDROID_COMPOSITOR_H_

OLD	NEW