Fixes to patch files necessary to use the analyzer

runtime/lib/mirrors.cc

Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index 3cf5a681a256b5f19c7f33caab153806eb72d558..f99b1113658259fec22b122b3e10ebedccef4fdb 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -1667,8 +1667,7 @@ DEFINE_NATIVE_ENTRY(ClassMirror_invokeConstructor, 5) {
       Array::Handle(ArgumentsDescriptor::New(args.Length(), arg_names));
 
   ArgumentsDescriptor args_descriptor(args_descriptor_array);
-  if (!redirected_constructor.AreValidArguments(args_descriptor, NULL) ||
-      !redirected_constructor.is_reflectable()) {
+  if (!redirected_constructor.AreValidArguments(args_descriptor, NULL)) {

[Kevin Millikin (Google), 2017/01/04 15:31:04]

We have already checked above (line 1600) that lookup_constructor --- the one
we're actually trying to invoke --- is reflectable.  I think it should not
matter if the redirection target is or is not.

Private members of SDK libraries are not reflectable.  If this check is left
here, it prevents mirrors from invoking the factory constructor List (which is
reflectable) because it redirects to List._internal (which is not reflectable).

I'm less sure about the NSM error message.  I've kept it the same, but it will
be in terms of the redirected constructor.

     external_constructor_name = redirected_constructor.name();
     ThrowNoSuchMethod(AbstractType::Handle(klass.RareType()),
                       external_constructor_name, redirected_constructor,