Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2612033002: Count exact cache size for time ranges (Closed)

Created:
3 years, 11 months ago by dullweber
Modified:
3 years, 11 months ago
Reviewers:
msramek
CC:
chromium-reviews, jam, markusheintz_, darin-cc_chromium.org, msramek+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Currently cache size in "Clear browsing data" dialog is shown as "Less than X" when selecting a time range (Where X is the total size of the cache). To fix this, I count the cache size depending on a chosen time range. The cache can be very big and we want a responsive ui, so if counting the cache takes too long I show the upper estimate instead. As a future improvement I would like to propose a specialized version for SimpleBackendImpl. It could determine the size of a subset of the cache from the EntryMetadata stored in memory. This should be fast enough for any cache size. BUG=671196 CQ-DEPEND=CL:2591743002

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -17 lines) Patch
M chrome/browser/browsing_data/cache_counter.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/browsing_data/cache_counter.cc View 3 chunks +39 lines, -3 lines 0 comments Download
M chrome/browser/browsing_data/cache_counter_browsertest.cc View 3 chunks +28 lines, -8 lines 0 comments Download
M chrome/browser/browsing_data/conditional_cache_counting_helper_browsertest.cc View 3 chunks +36 lines, -2 lines 0 comments Download
M components/browsing_data/content/conditional_cache_counting_helper.h View 4 chunks +12 lines, -0 lines 0 comments Download
M components/browsing_data/content/conditional_cache_counting_helper.cc View 4 chunks +51 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (10 generated)
dullweber
The cl with the code removed from http://crrev.com/2556363003
3 years, 11 months ago (2017-01-05 09:23:50 UTC) #9
msramek
3 years, 11 months ago (2017-01-05 09:34:30 UTC) #10
LGTM

Powered by Google App Engine
This is Rietveld 408576698