Media Session: use dictionary instead of an interface for MediaImage.

third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html

Index: third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
diff --git a/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html b/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
index a94f53171a6b53b7c78e940ac2bc562d81bcdc6a..7eb907f5fc73bf4955fae642d275e63b458dd4a0 100644
--- a/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
+++ b/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
@@ -18,17 +18,16 @@
   }, "Test that MediaMetadata constructor can take no parameter");
 
   test(function() {
+    var image1 = { src: 'http://example.com/1', sizes: 'sizes1', type: 'type1' };
+    var image2 = { src: 'http://example.com/2', sizes: 'sizes2', type: 'type2' };
     var metadata = new MediaMetadata({
-        title: 'foo', album: 'bar', artist: 'plop',
-        artwork: [ { src: 'src1', sizes: 'sizes1', type: 'type1'},
-                   { src: 'src2', sizes: 'sizes2', type: 'type2'} ] });
+        title: 'foo', album: 'bar', artist: 'plop', artwork: [ image1, image2 ]
+    });
+
     assert_equals(metadata.title, 'foo');
     assert_equals(metadata.album, 'bar');
     assert_equals(metadata.artist, 'plop');
-    assert_equals(2, metadata.artwork.length);
-
-    var image1 = new MediaImage({ src: 'src1', sizes: 'sizes1', type: 'type1'});
-    var image2 = new MediaImage({ src: 'src2', sizes: 'sizes2', type: 'type2'});
+    assert_equals(metadata.artwork.length, 2);
     assert_equals(metadata.artwork[0].src, image1.src);
     assert_equals(metadata.artwork[0].sizes, image1.sizes);
     assert_equals(metadata.artwork[0].type, image1.type);
@@ -59,10 +58,11 @@
   }, 'Test that passing unknown values to the dictionary is a no-op');
 
   test(function() {
+    var image1 = { src: 'http://example.com/1', sizes: 'sizes1', type: 'type1' };
+    var image2 = { src: 'http://example.com/2', sizes: 'sizes2', type: 'type2' };
     var metadata = new MediaMetadata({
-        title: 'foo', album: 'bar', artist: 'plop',
-        artwork: [ { src: 'src1', sizes: 'sizes1', type: 'type1'},
-                   { src: 'src2', sizes: 'sizes2', type: 'type2'} ] });
+      title: 'foo', album: 'bar', artist: 'plop', artwork: [ image1, image2 ]
+    });
 
     metadata.title = 'something else';
     assert_equals(metadata.title, 'something else');
@@ -73,7 +73,7 @@
     metadata.artist = 'someone else';
     assert_equals(metadata.artist, 'someone else');
 
-    var image = new MediaImage({ src: 'http://example.com/', sizes: '40x40', type: 'image/png' });
+    var image = { src: 'http://example.com/', sizes: '40x40', type: 'image/png' };
     metadata.artwork = [ image ];
     assert_equals(metadata.artwork.length, 1);
     assert_equals(metadata.artwork[0].src, 'http://example.com/');
@@ -81,4 +81,75 @@
     assert_equals(metadata.artwork[0].type, 'image/png');
   }, "Test that MediaMetadata is read/write");
 
+  test(function() {
+    var metadata = new MediaMetadata({ artwork: [ { src: 'http://foo.com/' } ] });
+    assert_throws(new TypeError(), _ => {
+      metadata.artwork.push({
+        src: 'http://example.com/', sizes: '40x40', type: 'image/png',
+      });
+    });
+
+    metadata.artwork[0].src = 'bar';
+    assert_equals(metadata.artwork[0].src, 'http://foo.com/');
+  }, "Test that MediaMetadat.artwork can't be modified");
+
+  test(function() {
+    var metadata = new MediaMetadata({ artwork: [{
+      src: 'http://example.com/', sizes: '40x40', type: 'image/png',
+      some_other_value: 'foo',
+    }]});
+    assert_equals(metadata.artwork[0].src, 'http://example.com/');
+    assert_equals(metadata.artwork[0].sizes, '40x40');
+    assert_equals(metadata.artwork[0].type, 'image/png');
+    assert_false('some_other_value' in metadata.artwork[0]);
+
+    metadata.artwork[0].something_else = 'bar';
+    assert_false('something_else' in metadata.artwork[0]);
+  }, "Test that MediaMetadata.artwork will not expose unknown properties");
+
+  test(function() {
+    var metadata = new MediaMetadata({ artwork: [
+      { src: 'http://example.com/1', sizes: '40x40', type: 'image/png' },
+      { src: 'http://example.com/2', sizes: '40x40', type: 'image/png' },
+    ]});
+
+    assert_true(Object.isFrozen(metadata.artwork));
+    for (var i = 0; i < metadata.artwork.length; ++i)
+      assert_true(Object.isFrozen(metadata.artwork[i]));
+  }, "Test that MediaMetadata.artwork is Frozen");
+
+  test(function() {
+    var metadata = new MediaMetadata({ artwork: [
+      { src: 'http://example.com', sizes: '40x40', type: 'image/png' },
+      { src: '../foo', sizes: '40x40', type: 'image/png' },
+      { src: '/foo/bar', sizes: '40x40', type: 'image/png' },
+    ]});
+
+    assert_equals(metadata.artwork[0].src, new URL('http://example.com', document.URL).href)
+    assert_equals(metadata.artwork[1].src, new URL('../foo', document.URL).href)
+    assert_equals(metadata.artwork[2].src, new URL('/foo/bar', document.URL).href)
+  }, "Test that MediaMetadata.artwork returns parsed urls");
+
+  test(function() {
+    var metadata = 42;
+
+    assert_throws(new TypeError(), _ => {
+      metadata
+        new MediaMetadata({ artwork: [ { src: 'http://[example.com]' }] });
+    });
+    assert_equals(metadata, 42);
+
+    metadata = new MediaMetadata();
+    assert_throws(new TypeError(), _ => {
+      metadata.artwork = [
+        // Valid url.
+        { src: 'http://example.com' },
+        // Invalid url.
+        { src: 'http://example.com:demo' },
+      ];
+    });
+    assert_equals(metadata.artwork.length, 0);
+
+  }, "Test that MediaMetadata throws when setting an invalid url");
+
 </script>