Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html

Issue 2612003002: Media Session: use dictionary instead of an interface for MediaImage. (Closed)
Patch Set: rebase and remove one more file Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
diff --git a/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html b/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
index a94f53171a6b53b7c78e940ac2bc562d81bcdc6a..fadadf9489faca12d8021ef3a82413d73188acf6 100644
--- a/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
+++ b/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
@@ -18,17 +18,16 @@
}, "Test that MediaMetadata constructor can take no parameter");
test(function() {
+ var image1 = { src: 'src1', sizes: 'sizes1', type: 'type1' };
+ var image2 = { src: 'src2', sizes: 'sizes2', type: 'type2'};
var metadata = new MediaMetadata({
- title: 'foo', album: 'bar', artist: 'plop',
- artwork: [ { src: 'src1', sizes: 'sizes1', type: 'type1'},
- { src: 'src2', sizes: 'sizes2', type: 'type2'} ] });
+ title: 'foo', album: 'bar', artist: 'plop', artwork: [ image1, image2 ]
+ });
+
assert_equals(metadata.title, 'foo');
assert_equals(metadata.album, 'bar');
assert_equals(metadata.artist, 'plop');
- assert_equals(2, metadata.artwork.length);
-
- var image1 = new MediaImage({ src: 'src1', sizes: 'sizes1', type: 'type1'});
- var image2 = new MediaImage({ src: 'src2', sizes: 'sizes2', type: 'type2'});
+ assert_equals(metadata.artwork.length, 2);
assert_equals(metadata.artwork[0].src, image1.src);
assert_equals(metadata.artwork[0].sizes, image1.sizes);
assert_equals(metadata.artwork[0].type, image1.type);
@@ -73,7 +72,7 @@
metadata.artist = 'someone else';
assert_equals(metadata.artist, 'someone else');
- var image = new MediaImage({ src: 'http://example.com/', sizes: '40x40', type: 'image/png' });
+ var image = { src: 'http://example.com/', sizes: '40x40', type: 'image/png' };
metadata.artwork = [ image ];
assert_equals(metadata.artwork.length, 1);
assert_equals(metadata.artwork[0].src, 'http://example.com/');
@@ -81,4 +80,30 @@
assert_equals(metadata.artwork[0].type, 'image/png');
}, "Test that MediaMetadata is read/write");
+ test(function() {
+ var metadata = new MediaMetadata({ artwork: [ { src: 'foo' } ] });
+ assert_throws(new TypeError(), _ => {
+ metadata.artwork.push({
+ src: 'http://example.com/', sizes: '40x40', type: 'image/png',
+ });
+ });
+
+ metadata.artwork[0].src = 'bar';
+ assert_equals(metadata.artwork[0].src, 'foo');
+ }, "Test that MediaMetadat.artwork can't be modified");
+
+ test(function() {
+ var metadata = new MediaMetadata({ artwork: [{
+ src: 'http://example.com/', sizes: '40x40', type: 'image/png',
+ some_other_value: 'foo',
+ }]});
+ assert_equals(metadata.artwork[0].src, 'http://example.com/');
+ assert_equals(metadata.artwork[0].sizes, '40x40');
+ assert_equals(metadata.artwork[0].type, 'image/png');
+ assert_false('some_other_value' in metadata.artwork[0]);
+
+ metadata.artwork[0].something_else = 'bar';
+ assert_false('something_else' in metadata.artwork[0]);
+ }, "Test that MediaMetadata.artwork will not expose unknown properties");
+
</script>

Powered by Google App Engine
This is Rietveld 408576698