third_party/WebKit/Source/modules/mediasession/MediaImage.idl - Issue 2612003002: Media Session: use dictionary instead of an interface for MediaImage.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/mediasession/MediaImage.idl

Issue 2612003002: Media Session: use dictionary instead of an interface for MediaImage. (Closed)

Patch Set: apply spec changes and comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://wicg.github.io/mediasession/#the-mediaimage-interface	5 // https://wicg.github.io/mediasession/#dictdef-mediaimage

6	6

7 [	7 dictionary MediaImage {

8 ConstructorCallWith=ExecutionContext,	8 USVString src;
	Zhiqiang Zhang (Slow) 2017/01/05 16:03:07 +required? +required? mlamouri (slow - plz ping) 2017/01/05 19:28:22 Done. Show quoted text On 2017/01/05 at 16:03:07, Zhiqiang Zhang wrote: > +required? Done.
9 Constructor(MediaImageInit image),	9 DOMString sizes;
	Zhiqiang Zhang (Slow) 2017/01/05 16:03:07 = "" ? = "" ? mlamouri (slow - plz ping) 2017/01/05 19:28:22 Done. Show quoted text On 2017/01/05 at 16:03:07, Zhiqiang Zhang wrote: > = "" ? Done.
10 RuntimeEnabled=MediaSession,	10 DOMString type;
	Zhiqiang Zhang (Slow) 2017/01/05 16:03:07 = "" ? = "" ? mlamouri (slow - plz ping) 2017/01/05 19:28:22 Done. Show quoted text On 2017/01/05 at 16:03:07, Zhiqiang Zhang wrote: > = "" ? Done.
11 ] interface MediaImage {

12 readonly attribute USVString src;

13 readonly attribute DOMString sizes;

14 readonly attribute DOMString type;

15 };	11 };

OLD	NEW