Refactors cvc and expiration date validation in CC upload logic as well as unmask prompt.

components/autofill/core/browser/validation.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/validation.h"
 
 #include <stddef.h>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
@@ skipping 69 matching lines @@
       sum += digit / 10 + digit % 10;
     } else {
       sum += digit;
     }
     odd = !odd;
   }
 
   return (sum % 10) == 0;
 }
 
 bool IsValidCreditCardSecurityCode(const base::string16& text) {

[Mathieu, 2017/01/04 18:20:17]

From quick codesearch, looks like this is unused. Can you do a cleanup of the
unused IsValidCreditCardSecurityCode function(s)?

[Moe, 2017/01/04 18:31:28]

Looks like it's being used in
https://cs.chromium.org/chromium/src/components/autofill/core/browser/validat...
as far as I can tell there's no unused function here.

[Mathieu, 2017/01/04 19:12:37]

Yes but I would say the test doesn't count. Let's remove the function and its
unittest

[Moe, 2017/01/05 05:25:20]

Oh i see. My bad. Removed the unused functions and modified the tests to cover
the new one. 

   if (text.size() < 3U || text.size() > 4U)
     return false;
-
-  for (const base::char16& it : text) {
-    if (!base::IsAsciiDigit(it))
-      return false;
-  }
-  return true;
+  return base::ContainsOnlyChars(text, base::ASCIIToUTF16("0123456789"));;

[Mathieu, 2017/01/04 18:20:17]

nit: double ;

[Moe, 2017/01/04 18:31:28]

Done.

 }
 
 bool IsValidCreditCardSecurityCode(const base::string16& code,
                                    const base::string16& number) {
-  const char* const type = CreditCard::GetCreditCardType(number);
-  size_t required_length = 3;
-  if (type == kAmericanExpressCard)
-    required_length = 4;
+  const char* const card_type = CreditCard::GetCreditCardType(number);
+  return IsValidCreditCardSecurityCode(code, card_type);
+}
 
-  return code.length() == required_length;
+bool IsValidCreditCardSecurityCode(const base::string16& code,
+                                   const base::StringPiece card_type) {
+  size_t required_length = card_type == kAmericanExpressCard ? 4 : 3;
+  return code.length() == required_length &&
+         base::ContainsOnlyChars(code, base::ASCIIToUTF16("0123456789"));
 }
 
 bool IsValidEmailAddress(const base::string16& text) {
   // E-Mail pattern as defined by the WhatWG. (4.10.7.1.5 E-Mail state)
   const base::string16 kEmailPattern = base::ASCIIToUTF16(
       "^[a-zA-Z0-9.!#$%&'*+/=?^_`{|}~-]+@"
       "[a-zA-Z0-9-]+(?:\\.[a-zA-Z0-9-]+)*$");
   return MatchesPattern(text, kEmailPattern);
 }
 
@@ skipping 63 matching lines @@
                                              number_string.begin() + 9),
                          &serial)
       || serial == 0) {
     return false;
   }
 
   return true;
 }
 
 }  // namespace autofill