Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2611813002: Add support for persisting CompositionUnderlines in InputMethodController (Closed)
Patch Set: Try one more time Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 37de94c31f43151b93d9904993a5ccf26834a1c1..2576a70b8961e24b36efff57b766dbbb23adf998 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -1420,7 +1420,7 @@ TEST_P(WebViewTest, SetCompositionFromExistingText) {
m_baseURL + "input_field_populated.html");
webView->setInitialFocus(false);
WebVector<WebCompositionUnderline> underlines(static_cast<size_t>(1));
- underlines[0] = WebCompositionUnderline(0, 4, 0, false, 0);
+ underlines[0] = WebCompositionUnderline(0, 4, 0, false, 0, false);
WebLocalFrameImpl* frame = webView->mainFrameImpl();
frame->setEditableSelectionOffsets(4, 10);
frame->setCompositionFromExistingText(8, 12, underlines);
@@ -1446,7 +1446,7 @@ TEST_P(WebViewTest, SetCompositionFromExistingTextInTextArea) {
m_webViewHelper.initializeAndLoad(m_baseURL + "text_area_populated.html");
webView->setInitialFocus(false);
WebVector<WebCompositionUnderline> underlines(static_cast<size_t>(1));
- underlines[0] = WebCompositionUnderline(0, 4, 0, false, 0);
+ underlines[0] = WebCompositionUnderline(0, 4, 0, false, 0, false);
WebLocalFrameImpl* frame = webView->mainFrameImpl();
WebInputMethodController* activeInputMethodController =
frame->frameWidget()->getActiveWebInputMethodController();
@@ -1489,7 +1489,7 @@ TEST_P(WebViewTest, SetCompositionFromExistingTextInRichText) {
m_baseURL + "content_editable_rich_text.html");
webView->setInitialFocus(false);
WebVector<WebCompositionUnderline> underlines(static_cast<size_t>(1));
- underlines[0] = WebCompositionUnderline(0, 4, 0, false, 0);
+ underlines[0] = WebCompositionUnderline(0, 4, 0, false, 0, false);
WebLocalFrameImpl* frame = webView->mainFrameImpl();
frame->setEditableSelectionOffsets(1, 1);
WebDocument document = webView->mainFrame()->document();

Powered by Google App Engine
This is Rietveld 408576698