Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodController.cpp

Issue 2611813002: Add support for persisting CompositionUnderlines in InputMethodController (Closed)
Patch Set: Try one more time Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/InputMethodController.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodController.cpp b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
index dbe4b6d7fc5e59efaede8a673e21fa99e854260d..f801bf743bd475a4b7f973c82d084f009c8830ee 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodController.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodController.cpp
@@ -346,7 +346,8 @@ void InputMethodController::addCompositionUnderlines(
document().markers().addCompositionMarker(
ephemeralLineRange.startPosition(), ephemeralLineRange.endPosition(),
- underline.color(), underline.thick(), underline.backgroundColor());
+ underline.color(), underline.thick(), underline.backgroundColor(),
+ underline.persist());
}
}
@@ -611,7 +612,8 @@ void InputMethodController::setComposition(
document().markers().addCompositionMarker(
m_compositionRange->startPosition(), m_compositionRange->endPosition(),
Color::black, false,
- LayoutTheme::theme().platformDefaultCompositionBackgroundColor());
+ LayoutTheme::theme().platformDefaultCompositionBackgroundColor(),
+ false);
return;
}
@@ -626,7 +628,8 @@ void InputMethodController::setComposition(
continue;
document().markers().addCompositionMarker(
ephemeralLineRange.startPosition(), ephemeralLineRange.endPosition(),
- underline.color(), underline.thick(), underline.backgroundColor());
+ underline.color(), underline.thick(), underline.backgroundColor(),
+ underline.persist());
}
}

Powered by Google App Engine
This is Rietveld 408576698