components/test_runner/text_input_controller.cc - Issue 2611813002: Add support for persisting CompositionUnderlines in InputMethodController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/text_input_controller.cc

Issue 2611813002: Add support for persisting CompositionUnderlines in InputMethodController (Closed)

Patch Set: Try one more time Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/test_runner/text_input_controller.cc

diff --git a/components/test_runner/text_input_controller.cc b/components/test_runner/text_input_controller.cc

index 05de1c83a2300f44f67dde98ab9cfe81b2cf260c..8a8a0cb5be24f4343bc202fad0375cc6b7432fcb 100644

--- a/components/test_runner/text_input_controller.cc

+++ b/components/test_runner/text_input_controller.cc

@@ -310,7 +310,7 @@ void TextInputController::SetComposition(const std::string& text) {

std::vector<blink::WebCompositionUnderline> underlines;

underlines.push_back(blink::WebCompositionUnderline(

- 0, textLength, SK_ColorBLACK, false, SK_ColorTRANSPARENT));

+ 0, textLength, SK_ColorBLACK, false, SK_ColorTRANSPARENT, false));

if (auto* controller = GetInputMethodController()) {

controller->setComposition(

newText, blink::WebVector<blink::WebCompositionUnderline>(underlines),