Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: components/spellcheck/renderer/spellcheck_unittest.cc

Issue 2611723003: [Sheriff] Disable SpellCheckTest.SpellCheckText on Windows (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/spellcheck/renderer/spellcheck_unittest.cc
diff --git a/components/spellcheck/renderer/spellcheck_unittest.cc b/components/spellcheck/renderer/spellcheck_unittest.cc
index 4077b8eb4d3a190ce5ef627483a1e4371bfe48cc..2257318532597c59d99cffd82f78146c3a52bdfa 100644
--- a/components/spellcheck/renderer/spellcheck_unittest.cc
+++ b/components/spellcheck/renderer/spellcheck_unittest.cc
@@ -489,9 +489,10 @@ TEST_F(SpellCheckTest, SpellCheckSuggestions_EN_US) {
// This test verifies our spellchecker can split a text into words and check
// the spelling of each word in the text.
-#if defined(THREAD_SANITIZER)
+#if defined(THREAD_SANITIZER) || defined(OS_WIN)
// SpellCheckTest.SpellCheckText fails under ThreadSanitizer v2.
// See http://crbug.com/217909.
+// Also fails on windows: crbug.com/678300.
#define MAYBE_SpellCheckText DISABLED_SpellCheckText
#else
#define MAYBE_SpellCheckText SpellCheckText
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698