Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: Source/core/dom/Document.idl

Issue 26117003: Drop NotEnumerable for the on* event handler IDL attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@svgtest
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.idl
diff --git a/Source/core/dom/Document.idl b/Source/core/dom/Document.idl
index 010eb4440bc3bba1f160d264d066705d599ea9dc..7fe8d2a9df282b161a0ce67fe17f215a3e51693f 100644
--- a/Source/core/dom/Document.idl
+++ b/Source/core/dom/Document.idl
@@ -170,62 +170,40 @@ callback CustomElementConstructor = Element ();
[RuntimeEnabled=FontLoadEvents] readonly attribute FontFaceSet fonts;
// Event handler DOM attributes
- [NotEnumerable] attribute EventHandler onabort;
- [NotEnumerable] attribute EventHandler onblur;
- [NotEnumerable] attribute EventHandler onchange;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onclick;
- [NotEnumerable] attribute EventHandler oncontextmenu;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler ondblclick;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler ondrag;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler ondragend;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler ondragenter;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler ondragleave;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler ondragover;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler ondragstart;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler ondrop;
- [NotEnumerable] attribute EventHandler onerror;
- [NotEnumerable] attribute EventHandler onfocus;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler oninput;
- [NotEnumerable] attribute EventHandler oninvalid;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onkeydown;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onkeypress;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onkeyup;
- [NotEnumerable] attribute EventHandler onload;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onmousedown;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onmouseenter;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onmouseleave;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onmousemove;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onmouseout;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onmouseover;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onmouseup;
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onmousewheel; // Deprecated in favor of onwheel.
- [NotEnumerable, ActivityLogging=Setter] attribute EventHandler onwheel;
- [NotEnumerable] attribute EventHandler onreadystatechange;
- [NotEnumerable] attribute EventHandler onscroll;
- [NotEnumerable] attribute EventHandler onselect;
- [NotEnumerable] attribute EventHandler onsubmit;
-
- // attribute [NotEnumerable] EventHandler oncanplay;
- // attribute [NotEnumerable] EventHandler oncanplaythrough;
- // attribute [NotEnumerable] EventHandler ondurationchange;
- // attribute [NotEnumerable] EventHandler onemptied;
- // attribute [NotEnumerable] EventHandler onended;
- // attribute [NotEnumerable] EventHandler onloadeddata;
- // attribute [NotEnumerable] EventHandler onloadedmetadata;
- // attribute [NotEnumerable] EventHandler onloadstart;
- // attribute [NotEnumerable] EventHandler onpause;
- // attribute [NotEnumerable] EventHandler onplay;
- // attribute [NotEnumerable] EventHandler onplaying;
- // attribute [NotEnumerable] EventHandler onprogress;
- // attribute [NotEnumerable] EventHandler onratechange;
- // attribute [NotEnumerable] EventHandler onseeked;
- // attribute [NotEnumerable] EventHandler onseeking;
- // attribute [NotEnumerable] EventHandler onshow;
- // attribute [NotEnumerable] EventHandler onstalled;
- // attribute [NotEnumerable] EventHandler onsuspend;
- // attribute [NotEnumerable] EventHandler ontimeupdate;
- // attribute [NotEnumerable] EventHandler onvolumechange;
- // attribute [NotEnumerable] EventHandler onwaiting;
+ attribute EventHandler onabort;
+ attribute EventHandler onblur;
+ attribute EventHandler onchange;
+ [ActivityLogging=Setter] attribute EventHandler onclick;
+ attribute EventHandler oncontextmenu;
+ [ActivityLogging=Setter] attribute EventHandler ondblclick;
+ [ActivityLogging=Setter] attribute EventHandler ondrag;
+ [ActivityLogging=Setter] attribute EventHandler ondragend;
+ [ActivityLogging=Setter] attribute EventHandler ondragenter;
+ [ActivityLogging=Setter] attribute EventHandler ondragleave;
+ [ActivityLogging=Setter] attribute EventHandler ondragover;
+ [ActivityLogging=Setter] attribute EventHandler ondragstart;
+ [ActivityLogging=Setter] attribute EventHandler ondrop;
+ attribute EventHandler onerror;
+ attribute EventHandler onfocus;
+ [ActivityLogging=Setter] attribute EventHandler oninput;
+ attribute EventHandler oninvalid;
+ [ActivityLogging=Setter] attribute EventHandler onkeydown;
+ [ActivityLogging=Setter] attribute EventHandler onkeypress;
+ [ActivityLogging=Setter] attribute EventHandler onkeyup;
+ attribute EventHandler onload;
+ [ActivityLogging=Setter] attribute EventHandler onmousedown;
+ [ActivityLogging=Setter] attribute EventHandler onmouseenter;
+ [ActivityLogging=Setter] attribute EventHandler onmouseleave;
+ [ActivityLogging=Setter] attribute EventHandler onmousemove;
+ [ActivityLogging=Setter] attribute EventHandler onmouseout;
+ [ActivityLogging=Setter] attribute EventHandler onmouseover;
+ [ActivityLogging=Setter] attribute EventHandler onmouseup;
+ [ActivityLogging=Setter] attribute EventHandler onmousewheel; // Deprecated in favor of onwheel.
+ [ActivityLogging=Setter] attribute EventHandler onwheel;
+ attribute EventHandler onreadystatechange;
+ attribute EventHandler onscroll;
+ attribute EventHandler onselect;
+ attribute EventHandler onsubmit;
// WebKit extensions
abarth-chromium 2013/10/15 16:58:52 I would have done these too and removed this comme
philipj_slow 2013/10/15 20:14:10 Done.
[NotEnumerable] attribute EventHandler onbeforecut;

Powered by Google App Engine
This is Rietveld 408576698