Make closedWorld a property of ClosedWorldRefiner.

Make closedWorld a property of ClosedWorldRefiner.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/a8b95d2b6f06a54242fe0dc28086e07fd08c57ff

[Johnni Winther, 2017-01-03 10:03:47]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-01-03 17:46:08]

lgtm

https://codereview.chromium.org/2611633002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/world_builder.dart (right):

https://codereview.chromium.org/2611633002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:501: ClosedWorld get
closedWorldForTesting {
do we still need this for testing, or should we be able to use the closedWorld
property you just added?

https://codereview.chromium.org/2611633002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:1141: ClosedWorld __world;
I guess this is really really private ;-)

[Johnni Winther, 2017-01-04 09:11:21]

https://codereview.chromium.org/2611633002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/world_builder.dart (right):

https://codereview.chromium.org/2611633002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/world_builder.dart:501: ClosedWorld get
closedWorldForTesting {
On 2017/01/03 17:46:08, Siggi Cherem (dart-lang) wrote:
> do we still need this for testing, or should we be able to use the closedWorld
> property you just added?

We still need it (kernel/closed_world_test). The ClosedWorldRefiner shouldn't be
created unless needed, so I prefer testing on this property.

[Johnni Winther, 2017-01-04 09:16:32]

Description was changed from

==========
Make closedWorld a property of ClosedWorldRefiner.
==========

to

==========
Make closedWorld a property of ClosedWorldRefiner.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a8b95d2b6f06a54242fe0dc28086e07fd08c57ff
==========

[Johnni Winther, 2017-01-04 09:16:33]

Committed patchset #1 (id:1) manually as
a8b95d2b6f06a54242fe0dc28086e07fd08c57ff (presubmit successful).