Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2611613004: Call Element::rebuildLayoutTree from Document::updateStyle directly (Closed)

Created:
3 years, 11 months ago by Bugs Nash
Modified:
3 years, 9 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call Element::rebuildLayoutTree from Document::updateStyle directly Reupload of issue 2473743003 patch 11. Also prevents recalcDescendantStyles when Reattach is required. BUG=595137, 658092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -30 lines) Patch
M third_party/WebKit/Source/core/dom/ContainerNode.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 5 chunks +51 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleReattachData.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Text.cpp View 1 chunk +20 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (9 generated)
Bugs Nash
The CQ bit was checked by bugsnash@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-04 01:26:54 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611613004/1
3 years, 11 months ago (2017-01-04 01:27:16 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-04 03:24:07 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/357318)
3 years, 11 months ago (2017-01-04 03:24:07 UTC) #4
nainar
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-17 02:33:59 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2611613004/1
3 years, 11 months ago (2017-01-17 02:34:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-17 04:10:12 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/364925)
3 years, 11 months ago (2017-01-17 04:10:13 UTC) #8
nainar
3 years, 10 months ago (2017-02-03 06:32:04 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698