Issue 26116008: Remove old FocusManager code from Aura.

Issue 26116008: Remove old FocusManager code from Aura. (Closed)

Created:
7 years, 2 months ago by Ben Goodger (Google)

Modified:
7 years, 2 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, tfarina, kalyank, ben+aura_chromium.org, ben+views_chromium.org, James Su, ben+corewm_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove old FocusManager code from Aura. Needed to add a simple TestFocusClient that can be used by tests, which were still using the old FocusManager. This allows us to remove some obsolete methods from FocusClient/RootWindow/etc. R=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229437

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -271 lines)			Patch
M	ash/shell.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/wm/dock/docked_window_layout_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/panels/panel_layout_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/aura.gyp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/aura/bench/bench_main.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	ui/aura/client/focus_client.h	View		2 chunks	+0 lines, -9 lines	0 comments	Download
M	ui/aura/demo/demo_main.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
D	ui/aura/focus_manager.h	View		1 chunk	+0 lines, -49 lines	0 comments	Download
D	ui/aura/focus_manager.cc	View		1 chunk	+0 lines, -105 lines	0 comments	Download
M	ui/aura/remote_root_window_host_win.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura/root_window.cc	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	ui/aura/root_window_host_win.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura/root_window_host_x11.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/aura/root_window_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/test/aura_test_helper.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/aura/test/test_cursor_client.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	ui/aura/test/test_focus_client.h	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
A	ui/aura/test/test_focus_client.cc	View	1 2	1 chunk	+70 lines, -0 lines	0 comments	Download
M	ui/aura/window.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/aura/window_unittest.cc	View		2 chunks	+0 lines, -62 lines	0 comments	Download
M	ui/shell/minimal_shell.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ui/views/controls/native/native_view_host_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/corewm/compound_event_filter.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/corewm/focus_controller.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/views/corewm/focus_controller.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/widget/desktop_aura/x11_desktop_handler.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

7 years, 2 months ago (2013-10-18 17:39:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r229437 (presubmit successful).

Expand Messages | Collapse Messages