Issue 26116004: Add gfx::Transform::TransformBox and TransformBoxReverse

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26116004: Add gfx::Transform::TransformBox and TransformBoxReverse (Closed)

Created:
7 years, 2 months ago by Ian Vollick

Modified:
7 years, 2 months ago

Reviewers:
ajuma

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add gfx::Transform::TransformBox and TransformBoxReverse These new functions do what you'd expect (they transform the given box and return the tightest axis align box containing the transformed result). I've also added tests for Transform::TransformRect and TransformRectReverse and updated their comments. Seems like this class has gotten a bit stale. R=ajuma@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228215

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+92 lines, -7 lines)			Patch
M	ui/gfx/transform.h	View	2 chunks	+19 lines, -7 lines	0 comments	Download
M	ui/gfx/transform.cc	View	2 chunks	+28 lines, -0 lines	0 comments	Download
M	ui/gfx/transform_unittest.cc	View	2 chunks	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/26116004/1

7 years, 2 months ago (2013-10-11 15:27:06 UTC) #3

Message was sent while issue was closed.

Change committed as 228215

Expand Messages | Collapse Messages