Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2611593002: Rework the replay test to be more correct (Closed)

Created:
3 years, 11 months ago by Brian Wilkerson
Modified:
3 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1025 lines, -91 lines) Patch
M pkg/analysis_server/lib/plugin/protocol/protocol.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/stress/replay/replay.dart View 19 chunks +119 lines, -59 lines 0 comments Download
M pkg/analysis_server/test/stress/utilities/git.dart View 3 chunks +12 lines, -3 lines 0 comments Download
A pkg/analysis_server/test/stress/utilities/logger.dart View 1 chunk +49 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/stress/utilities/server.dart View 7 chunks +839 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 11 months ago (2017-01-02 23:35:39 UTC) #2
scheglov
LGTM
3 years, 11 months ago (2017-01-02 23:48:37 UTC) #3
Brian Wilkerson
3 years, 11 months ago (2017-01-03 15:45:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e1a27c0c60526feeb375d114cb16b606cc7b3ed2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698