Change default force composite setting to true

Change default force composite setting to true

BUG=361729
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174521

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174734

[enne (OOO), 2014-05-14 20:19:43]

\o/

[esprehn, 2014-05-14 20:32:02]

By Grabthar's hammer, by the suns of Warvan, these tests shall be composited!

lgtm (one nit about a comment in there, maybe you can explain better in the
patch description or in the code why the hack in WebViewImpl::layout is
required.)

https://codereview.chromium.org/261143003/diff/80001/Source/web/WebSharedWork...
File Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/261143003/diff/80001/Source/web/WebSharedWork...
Source/web/WebSharedWorkerImpl.cpp:196:
m_webView->settings()->setAcceleratedCompositingEnabled(false);
This is so crazy, why does a SharedWorker even have a WebViewImpl? It's a
worker, there should be no view...

https://codereview.chromium.org/261143003/diff/80001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/261143003/diff/80001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:1725: // FIXME: This shouldn't be necessary to kick
pages into compositing mode.
Can you file a bug or add a better description?

[enne (OOO), 2014-05-14 20:42:19]

https://codereview.chromium.org/261143003/diff/80001/Source/web/WebSharedWork...
File Source/web/WebSharedWorkerImpl.cpp (right):

https://codereview.chromium.org/261143003/diff/80001/Source/web/WebSharedWork...
Source/web/WebSharedWorkerImpl.cpp:196:
m_webView->settings()->setAcceleratedCompositingEnabled(false);
On 2014/05/14 20:32:02, esprehn wrote:
> This is so crazy, why does a SharedWorker even have a WebViewImpl? It's a
> worker, there should be no view...

I was similarly confused.

https://codereview.chromium.org/261143003/diff/80001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/261143003/diff/80001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:1725: // FIXME: This shouldn't be necessary to kick
pages into compositing mode.
On 2014/05/14 20:32:02, esprehn wrote:
> Can you file a bug or add a better description?

Done.

[enne (OOO), 2014-05-14 20:57:10]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-05-14 20:57:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/261143003/100001

[enne (OOO), 2014-05-14 21:12:09]

Could I get a Source/web OWNERS review?

[adamk, 2014-05-14 21:18:46]

lgtm for Source/web/ (man, those shadow pages are just getting uglier all the
time...)

[enne (OOO), 2014-05-14 21:50:25]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-05-14 21:51:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/261143003/120001

[commit-bot: I haz the power, 2014-05-14 22:21:20]

Change committed as 174049

[enne (OOO), 2014-05-14 23:00:26]

A revert of this CL has been created in
https://codereview.chromium.org/281393002/ by enne@chromium.org.

The reason for reverting is: Breaks content_unittests that are unable to create
graphics layers (likely similar to the FrameLoaderClientImplTest here)..

[enne (OOO), 2014-05-15 19:29:20]

I found the crashes in content unit tests.  There were two issues.  One is a
NULL WebViewImpl::m_client crash.  The other is missing compositorSupport in
order to be able to create WebLayer derived types inside of GraphicsLayer:
https://codereview.chromium.org/287043002/

Once that above patch lands, I will reland this patch.

https://codereview.chromium.org/261143003/diff/160001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/261143003/diff/160001/Source/web/WebViewImpl....
Source/web/WebViewImpl.cpp:3810: if (!m_client)
Other parts of WebViewImpl are robust to a missing client.  This part needs to
be too now once the force composite by default flag is flipped and this code
path is hit in content unit tests.

[esprehn, 2014-05-15 20:54:50]

lgtm

[adamk, 2014-05-16 08:44:44]

lgtm

[enne (OOO), 2014-05-21 16:59:11]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2014-05-21 17:47:34]

The CQ bit was unchecked by enne@chromium.org

[enne (OOO), 2014-05-21 18:13:32]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2014-05-21 18:15:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/261143003/180001

[commit-bot: I haz the power, 2014-05-22 05:22:37]

Change committed as 174521

[danakj, 2014-05-23 19:19:08]

https://codereview.chromium.org/296983017/ will fix the print
preview/clicktoplay browser test crashes on chromeos.

[danakj, 2014-05-24 00:43:09]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-05-24 00:43:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/enne@chromium.org/261143003/180001

[commit-bot: I haz the power, 2014-05-24 00:54:25]

Change committed as 174734