Issue 261143002: Pepper: Remove file_utils from trusted plugin.

Issue 261143002: Pepper: Remove file_utils from trusted plugin. (Closed)

Created:
6 years, 7 months ago by teravest

Modified:
6 years, 7 months ago

Reviewers:
bbudge

CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Remove file_utils from trusted plugin. This change moves some file reading and JSON parsing for pnacl resource info outside the trusted plugin. This allows us to remove file_utils entirely from the trusted plugin. BUG=239656 R=bbudge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268578

Patch Set 1 : fix dependencies #

Total comments: 1

Patch Set 2 : bug fixes #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Patch Set 5 : include order #

Patch Set 6 : rebased #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -187 lines)			Patch
M	components/nacl/renderer/ppb_nacl_private_impl.cc	View	1 2 3 4 5	3 chunks	+69 lines, -1 line	0 comments	Download
M	ppapi/api/private/ppb_nacl_private.idl	View	1 2 3	1 chunk	+8 lines, -0 lines	0 comments	Download
M	ppapi/c/private/ppb_nacl_private.h	View	1 2 3	2 chunks	+8 lines, -1 line	0 comments	Download
D	ppapi/native_client/src/trusted/plugin/file_utils.h	View		1 chunk	+0 lines, -38 lines	0 comments	Download
D	ppapi/native_client/src/trusted/plugin/file_utils.cc	View		1 chunk	+0 lines, -77 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/plugin.gypi	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_resources.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/pnacl_resources.cc	View	1 2 3	3 chunks	+14 lines, -64 lines	0 comments	Download
M	ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c	View	1 2 3 4 5	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

bbudge

LGTM w comment https://codereview.chromium.org/261143002/diff/30001/ppapi/api/private/ppb_nacl_private.idl File ppapi/api/private/ppb_nacl_private.idl (right): https://codereview.chromium.org/261143002/diff/30001/ppapi/api/private/ppb_nacl_private.idl#newcode403 ppapi/api/private/ppb_nacl_private.idl:403: PP_Bool GetPnaclResourceInfo([in] PP_Instance instance, I know ...

6 years, 7 months ago (2014-05-02 20:14:15 UTC) #2