Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2611423002: Fix type error in js_dart2js.dart caught by DDC. (Closed)

Created:
3 years, 11 months ago by Jacob
Modified:
3 years, 11 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix type error in js_dart2js.dart caught by DDC. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/badfd146d224e9a083cb038532273fa5f359e2ce

Patch Set 1 #

Patch Set 2 : Fix noSuchMethod handling of methods that are also extension methods. Fix noSuchMethod handling of … #

Patch Set 3 : Fix noSuchMethod handling of methods that are also extension methods. Fix noSuchMethod handling of … #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -34 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 1 chunk +25 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 1 chunk +25 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 1 chunk +25 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 1 chunk +25 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 6 chunks +29 lines, -27 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 1 1 chunk +18 lines, -1 line 0 comments Download
M tests/lib_strong/collection/list_test.dart View 1 2 2 chunks +52 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
3 years, 11 months ago (2017-01-06 22:56:49 UTC) #2
vsm
lgtm
3 years, 11 months ago (2017-01-07 02:01:46 UTC) #3
Jacob
3 years, 11 months ago (2017-01-09 15:42:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
badfd146d224e9a083cb038532273fa5f359e2ce (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698