Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.cc

Issue 2611403002: Fix a bug in drawBuffers optimization. (Closed)
Patch Set: update Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/framebuffer_manager.cc
diff --git a/gpu/command_buffer/service/framebuffer_manager.cc b/gpu/command_buffer/service/framebuffer_manager.cc
index 0fd59c5fd6ba1dfb618709f97b1a8269481fd6d2..63912958a87ebbe2d25f91401d13cdd6d7959438 100644
--- a/gpu/command_buffer/service/framebuffer_manager.cc
+++ b/gpu/command_buffer/service/framebuffer_manager.cc
@@ -525,21 +525,33 @@ bool Framebuffer::ValidateAndAdjustDrawBuffers(
if ((mask & fragment_output_type_mask) != (mask & draw_buffer_type_mask_))
return false;
- if (mask != adjusted_draw_buffer_bound_mask_) {
- // This won't be reached in every draw/clear call - only when framebuffer
- // or program has changed.
- for (uint32_t ii = 0; ii < manager_->max_draw_buffers_; ++ii) {
- adjusted_draw_buffers_[ii] = draw_buffers_[ii];
- uint32_t shift_bits = ii * 2;
- uint32_t buffer_mask = 0x3 << shift_bits;
- if ((buffer_mask & mask) == 0u) {
- adjusted_draw_buffers_[ii] = GL_NONE;
- }
+ AdjustDrawBuffersImpl(mask);
+ return true;
+}
+
+void Framebuffer::AdjustDrawBuffers() {
+ AdjustDrawBuffersImpl(draw_buffer_bound_mask_);
+}
+
+void Framebuffer::AdjustDrawBuffersImpl(uint32_t desired_mask) {
+ if (desired_mask == adjusted_draw_buffer_bound_mask_) {
+ return;
+ }
+ // This won't be reached in every clear call - only when framebuffer has
+ // changed.
+ for (uint32_t ii = 0; ii < manager_->max_draw_buffers_; ++ii) {
+ adjusted_draw_buffers_[ii] = draw_buffers_[ii];
+ if (adjusted_draw_buffers_[ii] == GL_NONE) {
+ continue;
+ }
+ uint32_t shift_bits = ii * 2;
+ uint32_t buffer_mask = 0x3 << shift_bits;
+ if ((buffer_mask & desired_mask) == 0u) {
+ adjusted_draw_buffers_[ii] = GL_NONE;
}
- adjusted_draw_buffer_bound_mask_ = mask;
- glDrawBuffersARB(manager_->max_draw_buffers_, adjusted_draw_buffers_.get());
}
- return true;
+ adjusted_draw_buffer_bound_mask_ = desired_mask;
+ glDrawBuffersARB(manager_->max_draw_buffers_, adjusted_draw_buffers_.get());
}
bool Framebuffer::ContainsActiveIntegerAttachments() const {
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698